Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Improve test network loading state indicator #5686

Closed
wants to merge 1 commit into from
Closed

WIP: Improve test network loading state indicator #5686

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 6, 2018 •
edited by ghost
Loading

Fixes #3776

  • Update the UI to include the network name next to the small spinner on the top bar of the extension.

cast

  • Show modal if connection attempt lasts longer than 15 seconds - TODO

@ghost ghost requested review from alextsg, danjm and whymarrh as code owners November 6, 2018 05:05
@whymarrh
Copy link
Contributor

whymarrh commented Nov 6, 2018

@anukul thanks for this, when this is ready for review feel free to remove the WIP prefix from the title

@ghost ghost closed this Nov 8, 2018
@ghost ghost deleted the 3776 branch November 8, 2018 09:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextsg alextsg Awaiting requested review from alextsg

@danjm danjm Awaiting requested review from danjm

@whymarrh whymarrh Awaiting requested review from whymarrh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whymarrh @anukul