EIP-1102: Transitionary API #5256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danfinlay
reviewed
Sep 13, 2018
app/scripts/inpage.js
Outdated
| // Augment the provider with its enable method | ||
| inpageProvider.enable = function () { | ||
| return new Promise((resolve) => { | ||
| resolve(inpageProvider.send({ method: 'eth_accounts' }).result) |
There was a problem hiding this comment.
Does inpageProvider.send({ method: 'eth_accounts' }) return a synchronous result, for grabbing .result off of?
There was a problem hiding this comment.
I think I would rather use the async method and return that method, these sync methods historically are unreliable.
There was a problem hiding this comment.
Updated. We can't return it directly since enable technically resolves directly to the array of accounts, but we can definitely use the async version.
danfinlay
previously approved these changes
Sep 13, 2018
bitpshr
force-pushed
the
eip-1102-mock
branch
from
8f1025b to
2d74a6c
Compare
7 tasks
2-am-zzz
approved these changes
Sep 14, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a transitionary EIP-1102 API so dapps can begin preemptively calling it. Specifically, this pull request does the following:
window.ethereumprovider#enablemethodNote: User-rejection can be tested by passing an object into the
enablemethod with amockRejectionproperty set totrue: