Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect token feature #4844

Merged
merged 14 commits into from
Jul 21, 2018
Merged

Detect token feature #4844

merged 14 commits into from
Jul 21, 2018

Conversation

estebanmino
Copy link
Contributor

Fix detection on submit password

@estebanmino
Copy link
Contributor Author

estebanmino commented Jul 21, 2018 •
edited
Loading

Auto detection wasn't working entirely when user submitPassword, state variable isActive from MetamaskController updates after KeyringController's isUnlocked does with this behaviour the functions to auto detect tokens were being triggered but not executing the detection.
Refactor to save an internal isActive state in DetectTokensController depending on isOpen state from MetamaskController and KeyringController's isUnlocked state.

@metamaskbot
Copy link
Collaborator

Builds ready [9be2277]: mascara, chrome, firefox, edge, opera

danfinlay
danfinlay approved these changes Jul 21, 2018
View reviewed changes
Copy link
Contributor

@danfinlay danfinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@danfinlay danfinlay merged commit c5520de into develop Jul 21, 2018
@estebanmino estebanmino deleted the detectTokenFeature branch July 26, 2018 14:00
@bdresser bdresser mentioned this pull request Aug 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danfinlay danfinlay danfinlay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estebanmino @metamaskbot @danfinlay