Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with scrollbar in currency display. #4647

Merged
merged 3 commits into from
Jun 29, 2018
Merged

Fix issues with scrollbar in currency display. #4647

merged 3 commits into from
Jun 29, 2018

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Jun 22, 2018 •
edited
Loading

Before:
sendtokencurrencydisplaybroken

After:
newsendtokenoverflow

@danjm danjm requested a review from whymarrh June 22, 2018 16:26
@danjm
Copy link
Contributor Author

danjm commented Jun 25, 2018

I'm also adding a firefox specific fix on the currency display in the amount row of the send screen to this PR with commit bc50f11 to address point (b) of #4645

It now looks like:

tokensendfirefox

@danjm danjm mentioned this pull request Jun 25, 2018
Closed
@danjm danjm force-pushed the fix-overflow-currency-display branch from bc50f11 to d2845af Compare June 29, 2018 00:15
@metamaskbot
Copy link
Collaborator

Builds ready [d2845af]: mascara, chrome, firefox, edge, opera

alextsg
alextsg previously approved these changes Jun 29, 2018
View reviewed changes
ui/app/components/send_/send-content/send-amount-row/send-amount-row.component.js Outdated
@@ -95,6 +95,7 @@ export default class SendAmountRow extends Component {
primaryCurrency={primaryCurrency || 'ETH'}
selectedToken={selectedToken}
value={amount}
step={'any'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

step="any"

@metamaskbot
Copy link
Collaborator

Builds ready [464b978]: mascara, chrome, firefox, edge, opera

@danjm danjm merged commit f6238b2 into develop Jun 29, 2018
@whymarrh whymarrh deleted the fix-overflow-currency-display branch June 29, 2018 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextsg alextsg alextsg approved these changes

@whymarrh whymarrh Awaiting requested review from whymarrh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danjm @metamaskbot @alextsg