Push new notice on recent phishing incidents #4566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 13, 2018 13:51
|
Looks like our integration tests are currently opinionated about the number of notifications shown. @tmashuang do you think you could make these tests more general? |
|
currently the phishing warning is coming BEFORE normal startup notices like the privacy notice |
|
That’s strange. Notices should probably appear chronologically. |
|
picking this up |
danfinlay
previously approved these changes
Jun 14, 2018
|
nah tests are not dynamic yet |
|
i think we should remove ToS and privacy from notices, and move notices to a more in-app notification thing. then we can also move notices to something we can deploy live out of scope of this PR, needs design, yada yada |
|
for now hard coding the phishing warning in integration tests |
|
ok heres my last attempt for tonight |
danfinlay
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need someone to manually QA this before we merge--I am unable to get my builds working locally.
This adds a new notice to our notice controller, allowing us to notify all of our users on next update of the recent phishing concerns.