Integration ENS with IPFS #4405

PhyrexTsai · 2018-05-30T04:36:12Z

Simple Summary

This implementation is to build a way to resolves ENS domains (.eth) to IPFS hash and redirects to url content.

Motivation

MetaMask browser extension is great project helps users to interact with Ethereum, and furthermore can be more powerful by add content resolve by ENS.

Specification

Resolve from ENS Public Resolver getContent hash to IPFS hash, and redirect url to ipfs.infura.io.

Demo

Video

https://www.dropbox.com/s/8g8y42z6w7e6bcj/metamask.mov?dl=0

kumavis · 2018-05-30T05:40:19Z

@PhyrexTsai this is awesome, please give us time to review it!

PhyrexTsai · 2018-05-31T09:25:31Z

@kumavis Thank you! Please let me know if there's anything needed to be changed.

danfinlay

Just commenting for now, there are a few other opinions I'd like to get on parts of this.

danfinlay · 2018-06-01T01:05:38Z

app/404.html

+<body>
+    <div class="app">
+        <img src="./images/404.png" alt="">
+        <h2>Powered by <a href="https://www.portal.network/">Portal Network</a></h2>


I wasn't sure how I felt about this at first, but you know, getting credit for what you do seems pretty fair. I'm fine leaving it up, at least for a while. The same way we link to 409H for the phishing detector.

danfinlay · 2018-06-01T01:06:12Z

app/manifest.json

+  },
+  "content_security_policy": "script-src 'self' 'unsafe-eval'; object-src 'self'"


Is there a way to not include the unsafe-eval permission?

Just remove it.

danfinlay · 2018-06-01T01:06:21Z

app/manifest.json

@@ -1,7 +1,7 @@
 {
  "name": "__MSG_appName__",
  "short_name": "__MSG_appName__",
-  "version": "4.6.0",
+  "version": "4.6.2",


Please leave the version bumping to us.

danfinlay · 2018-06-01T01:08:31Z

app/manifest.json

  ],
  "web_accessible_resources": [
-    "inpage.js"
+    "inpage.js",
+    "*"


I don't think we want to make all resources web-accessible. This seems like a potential privacy breech.

I think you should specifically list the files needed to display the page statuses (html, images).

Sure, I have removed it.

danfinlay · 2018-06-01T01:10:37Z

app/scripts/lib/ipfsContent.js

+
+            resolver.resolve(name, provider).then(ipfsHash => {
+                clearTimeout(clearTime)
+                let url = 'https://gateway.ipfs.io/ipfs/' + ipfsHash


Are we sure we want to hit IPFS gateway and not Infura?

Sending this comment to Infura for comment.

Sure, I have changed to the ipfs.infura.io

danfinlay · 2018-06-01T01:13:15Z

app/scripts/lib/resolver.js

+function getProvider (type) {
+  switch (type) {
+    case 'mainnet':
+      return 'https://mainnet.infura.io/'


I would rather we use the user's provider, provided by MetaMask, to reduce our number of blockchain connections, but for this feature, I can see the benefit of this simplicity, there aren't other chains w/ the ENS resolver anyway, this could be optimized later...

No problem, we will keep updating this part in the future.

yo no estoy de acuerdo en la utilización de trezor, para poder retirar mi fondos

egalano · 2018-06-01T05:12:32Z

@danfinlay you can use https://ipfs.infura.io for this. We've put a lot of work into preparing for additional traffic for IPFS.

danfinlay · 2018-06-02T20:30:48Z

@PhyrexTsai this would be very nicely accompanied by:

A tutorial of how to post sites in this way.
Some sample sites that work with this. The gif goes by quickly, we want to be able to show it off in full force when it comes out.
A blog post for when we publish. I'll draft this one, but offer you a review before I post it.

danfinlay · 2018-06-02T21:08:11Z

I've verified this works with phyrextsai.eth, it looks good, sorry for taking so long to try.

When I got it working, at first it usually didn't work, so I think it maybe only works with new tabs after installation, not sure why it was intermittently not working on first uses.

I mostly just want a guide on creating compatible sites, so others can build on this as soon as we release.

danfinlay

Works alright, has some issues with first time usage, and it doesn't save user's typed items, but does work with links like http://phyrextsai.eth, so that's cool, a blog post will really make this valuable to the community, but that doesn't need to block inclusion.

PhyrexTsai · 2018-06-10T15:17:49Z

@danfinlay Sorry for the late reply, I have write a tutorial of how to post websites by using IPFS and interact with ENS.

Tutorial link: https://gist.github.com/PhyrexTsai/cffcbfa1d752b9cf817d920dfcd1ec9f

And also have some website already deployed

PhyrexTsai · 2018-06-10T15:21:36Z

app/scripts/background.js

@@ -154,6 +158,7 @@ async function initialize () {
  const initLangCode = await getFirstPreferredLangCode()
  await setupController(initState, initLangCode)
  log.debug('MetaMask initialization complete.')


@danfinlay For the first time can not connect with, the issue that the initState.NetworkController.provider is undefined, so I think we can have a default value for this issue.

The fix code look likes:

let defaultProvider = initState.NetworkController === undefined ? { type: "mainnet" } : initState.NetworkController.provider; ipfsContent(defaultProvider);

danfinlay · 2018-06-11T22:29:33Z

The guide looks great @PhyrexTsai. Would you mind if we reposted that on our blog when it's time to publish?

PhyrexTsai · 2018-06-12T03:18:38Z

@danfinlay Sure, that will be great, thank you very much

kumavis · 2018-06-14T05:04:27Z

we're cutting a bug fix release tomorrow, then this will go in after with the next batch of larger features 😸
thank you for your patience

Arachnid · 2018-06-14T11:03:08Z

Any way to make this resolve to the IPFS content, rather than redirecting to it?

pimato · 2018-06-14T20:21:39Z

@PhyrexTsai @danfinlay @kumavis thanks for creating/adding this very important feature. Can´t wait to move the oasis products to IPFS/ENS.

alexvandesande · 2018-06-15T15:19:37Z

@Arachnid does a plugin has the right to change DNS hosts and actually register a "eth" TLD, so it looks like a traditional address? Honestly it would be great, but I would understand if google didn't permitted it as it would make phishing powers of extensions much worse

bgits · 2018-06-21T13:28:18Z

Shouldn't this feature use IPLD instead of IPFS? The content field could be a hash pointing to content stored in all kinds of protocols not just IPFS.

Georgi87 · 2018-06-27T06:31:58Z

Are pathnames forwarded? E.g. if I go to mywebsite.eth/home it should redirect to /home

Event better would be to resolve IPFS content directly. Is this possible to do in a chrome extension @PhyrexTsai ?

decanus · 2018-06-27T06:37:23Z

From what I’ve seen, you can resolve content directly if you register a new scheme. So like ipfs:// instead of http://

@Georgi87

As @Georgi87 mentioned about pathnames on the domain like `http://phyrextsai.eth/home` will pass to IPFS hash and append `/home` on redirection url. You can try the example below: http://phyrextsai.eth/index.html http://phyrextsai.eth/images/phyrex.jpg

PhyrexTsai · 2018-06-29T06:03:32Z

@danfinlay @Georgi87 I have committed the feature to let the mechanism in the pathnames of .eth domain working as the same in the ordinary domain.

Example:
http://phyrextsai.eth/index.html
http://phyrextsai.eth/images/phyrex.jpg

danfinlay · 2018-07-03T17:19:41Z

A few files are not passing our linting rules. We can either:

Fix these on this branch.
Add these files to the lint exceptions list.
Move these files outside of this repository.

The affected files are:

app/scripts/lib/ipfsContent.js
app/scripts/lib/contracts/registrar.js

These errors can be seen here:
https://circleci.com/gh/MetaMask/metamask-extension/31652?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Or by running: npm run lint.

These may be automatically fixable by running npm run lint:fix.

brunobar79 · 2018-07-03T18:12:24Z

@PhyrexTsai Please check PortalNetwork#4

If you merge that into your branch and push, all the test / lint errors should go away

Lint fix for Integration ENS with IPFS

PhyrexTsai · 2018-07-04T01:45:48Z

@danfinlay @brunobar79 Thanks for helping, I've merged the PR on this branch.

danfinlay

Let's do this!

jdetychey · 2018-08-03T12:16:41Z

can't wait for this 🚀

Arachnid · 2018-08-07T09:06:27Z

Note that not all ENS names will end in .eth. Can you make this work for other TLDs too?

bgits · 2018-08-07T12:18:38Z

@Arachnid What are the planned TLD's or how will new TLD's be proposed and added?

Arachnid · 2018-08-07T13:51:21Z

@bgits .luxe and .dds are likely to be added in the very near future, and correspond to their DNS equivalents. In the longer run, nearly any DNS TLD will be supported via DNSSEC proofs.

mryellow · 2018-08-08T22:14:13Z

app/manifest.json

+    "https://*.infura.io/",
+    "activeTab",
+    "webRequest",
+    "*://*.eth/"


This seems to appear in permissions dialog for Chrome as "eth websites" without an indication it's talking about a TLD. Leaving the user wondering "What is an eth website?"

MikeCheng1208 and others added 8 commits May 29, 2018 12:38

Intergrate ENS with IPFS

695b157

setTimeout bug fix

88a6b4e

Intergrate ENS with IPFS

8b8cc94

Update manifest.json

86ead43

Rename files

829deac

Update lib

384cb12

Update default provider

181a11e

Update app

68d119c

danfinlay reviewed Jun 1, 2018

View reviewed changes

PhyrexTsai added 2 commits June 1, 2018 11:26

Update manifest.json

4e14313

Update ipfs to infura

77d17f2

PhyrexTsai added 3 commits June 1, 2018 15:30

Update 404

cc5bdad

Merge branch 'develop' into portal-metamask

f90d070

Update 404.html

8a571ec

danfinlay previously approved these changes Jun 2, 2018

View reviewed changes

PhyrexTsai commented Jun 10, 2018

View reviewed changes

bgits mentioned this pull request Jun 14, 2018

[Draft] Resolve ENS domains in browser status-im/status-mobile#4772

Closed

danfinlay mentioned this pull request Jun 17, 2018

IDEX exchange may be suffering some hacks #4595

Closed

bitpshr mentioned this pull request Jun 25, 2018

Add support for .test ENS domains #4656

Merged

PhyrexTsai dismissed danfinlay’s stale review via 11736e6 June 29, 2018 05:57

brunobar79 and others added 3 commits July 3, 2018 14:21

Merge remote-tracking branch 'upstream/develop' into HEAD

595447c

fix lint errors

13b03ec

Merge pull request #4 from brunobar79/portal-metamask-lint-fix

f38dc03

Lint fix for Integration ENS with IPFS

danfinlay approved these changes Jul 4, 2018

View reviewed changes

danfinlay merged commit 68e1f22 into MetaMask:develop Jul 4, 2018

bdresser mentioned this pull request Jul 10, 2018

Host metamask.io with IPFS + ENS #4767

Closed

bdresser mentioned this pull request Aug 8, 2018

Updated metamask asks for additional permissions #4978

Closed

mryellow reviewed Aug 8, 2018

View reviewed changes

		},
		"content_security_policy": "script-src 'self' 'unsafe-eval'; object-src 'self'"

Integration ENS with IPFS #4405

Integration ENS with IPFS #4405

Conversation

PhyrexTsai commented May 30, 2018 • edited Loading

Simple Summary

Motivation

Specification

Demo

Video

kumavis commented May 30, 2018

PhyrexTsai commented May 31, 2018

danfinlay left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

egalano commented Jun 1, 2018

danfinlay commented Jun 2, 2018

danfinlay commented Jun 2, 2018

danfinlay left a comment • edited Loading

Choose a reason for hiding this comment

PhyrexTsai commented Jun 10, 2018

PhyrexTsai Jun 10, 2018 • edited Loading

Choose a reason for hiding this comment

danfinlay commented Jun 11, 2018

PhyrexTsai commented Jun 12, 2018

kumavis commented Jun 14, 2018

Arachnid commented Jun 14, 2018

pimato commented Jun 14, 2018

alexvandesande commented Jun 15, 2018

bgits commented Jun 21, 2018

Georgi87 commented Jun 27, 2018

decanus commented Jun 27, 2018 • edited Loading

PhyrexTsai commented Jun 29, 2018 • edited Loading

danfinlay commented Jul 3, 2018

brunobar79 commented Jul 3, 2018 • edited Loading

PhyrexTsai commented Jul 4, 2018

danfinlay left a comment

Choose a reason for hiding this comment

jdetychey commented Aug 3, 2018

Arachnid commented Aug 7, 2018

bgits commented Aug 7, 2018

Arachnid commented Aug 7, 2018

Choose a reason for hiding this comment

PhyrexTsai commented May 30, 2018 •

edited

Loading

danfinlay left a comment •

edited

Loading

PhyrexTsai Jun 10, 2018 •

edited

Loading

decanus commented Jun 27, 2018 •

edited

Loading

PhyrexTsai commented Jun 29, 2018 •

edited

Loading

brunobar79 commented Jul 3, 2018 •

edited

Loading