Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove scroll to the bottom requirement for all personal sign requests #29053

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Dec 10, 2024

Description

Users can now Confirm personal sign requests without scrolling to the bottom of the confirmation.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3760

Manual testing steps

  1. Go to OpenSea
  2. Login
  3. See their personal sign request and how the Confirm button is disabled

Screenshots/Recordings

Before

After

Screenshot 2024-12-10 at 14 16 32

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Dec 10, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Dec 10, 2024
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner December 10, 2024 14:21
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pedronfigueiredo pedronfigueiredo changed the title Remove scroll to the bottom requirement for all personal sign requests feat: Remove scroll to the bottom requirement for all personal sign requests Dec 10, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [1f9345b]
Page Load Metrics (1897 ± 87 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27425301823396190
domContentLoaded16612515187917886
load16702537189718187
domInteractive249534168
backgroundConnect96922178
firstReactRender169623178
getState892921424823
initialActions01000
loadScripts12651976145115474
setupStore711811
uiStartup19562762220918388
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 205 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [f083409]
Page Load Metrics (2032 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44424851932369177
domContentLoaded17682459198515976
load18782488203214168
domInteractive267538147
backgroundConnect11194534622
firstReactRender1794362713
getState713911618441
initialActions01000
loadScripts13341978155414268
setupStore777192311
uiStartup209328992459244117
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 222 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit b7aab59 Dec 12, 2024
75 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/3760 branch December 12, 2024 16:18
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
@metamaskbot metamaskbot added the release-12.10.1 Issue or pull request that will be included in release 12.10.1 label Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.1 Issue or pull request that will be included in release 12.10.1 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants