-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Only check attributions on release candidates #29043
Conversation
The `check-attributions` workflow has been updated to only check on release candidates, as was initially intended. Fixes #29037
@@ -3,13 +3,6 @@ name: Check Attributions | |||
on: | |||
push: | |||
branches: Version-v* | |||
pull_request: | |||
branches: Version-v* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
branches
here refers to the target branch, rather than the HEAD branch. That's why this was running on cherry pick PRs.
Builds ready [0209169]
Page Load Metrics (2056 ± 89 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
The
check-attributions
workflow has been updated to only check on release candidates, as was initially intended.Related issues
Fixes #29037
Manual testing steps
We could test this by creating a pretend release candidate, but that would mess up some of our other metrics/release automation. In this case it seems easier to test this by merging it, there are no significant negative consequences if it doesn't work as intended.
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist