Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Only check attributions on release candidates #29043

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Dec 10, 2024

Description

The check-attributions workflow has been updated to only check on release candidates, as was initially intended.

Open in GitHub Codespaces

Related issues

Fixes #29037

Manual testing steps

We could test this by creating a pretend release candidate, but that would mess up some of our other metrics/release automation. In this case it seems easier to test this by merging it, there are no significant negative consequences if it doesn't work as intended.

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

The `check-attributions` workflow has been updated to only check on
release candidates, as was initially intended.

Fixes #29037
@@ -3,13 +3,6 @@ name: Check Attributions
on:
push:
branches: Version-v*
pull_request:
branches: Version-v*
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

branches here refers to the target branch, rather than the HEAD branch. That's why this was running on cherry pick PRs.

See https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request

@Gudahtt Gudahtt marked this pull request as ready for review December 10, 2024 01:52
@metamaskbot
Copy link
Collaborator

Builds ready [0209169]
Page Load Metrics (2056 ± 89 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16882487205218388
domContentLoaded16822479202518288
load16872494205618689
domInteractive268545188
backgroundConnect797333014
firstReactRender1610424199
getState934051416330
initialActions01000
loadScripts12711971156816077
setupStore7191031
uiStartup191530262388253121
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@itsyoboieltr itsyoboieltr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit e9ea5b2 Dec 12, 2024
86 checks passed
@Gudahtt Gudahtt deleted the only-check-attributions-on-rcs branch December 12, 2024 18:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
@metamaskbot metamaskbot added the release-12.10.2 Issue or pull request that will be included in release 12.10.2 label Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.2 Issue or pull request that will be included in release 12.10.2 team-extension-platform team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: check-attributions workflow runs on PRs targeting a release candidate.
4 participants