Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: force @solana/web3.js version resolution #28926

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Dec 4, 2024

Description

Due to this Advisory, this PR forces the resolution of the affected package version to the current one (unaffected), avoiding unintentional updates to affected versions

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mikesposito mikesposito marked this pull request as ready for review December 4, 2024 14:53
@mikesposito mikesposito requested a review from a team as a code owner December 4, 2024 14:53
@mikesposito mikesposito changed the title chore: force @solana/web3.js version chore: force @solana/web3.js version resolution Dec 4, 2024
@danjm
Copy link
Contributor

danjm commented Dec 4, 2024

should we patch to the fixed version 1.95.8, and also allow versions higher than that?

danjm
danjm previously approved these changes Dec 4, 2024
FrederikBolding
FrederikBolding previously approved these changes Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [aad5cfe]
Page Load Metrics (1995 ± 98 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16772395199219996
domContentLoaded16542324196019995
load16752399199520598
domInteractive24513384
backgroundConnect97829199
firstReactRender159024167
getState1203951575727
initialActions01000
loadScripts12311825149717986
setupStore7261142
uiStartup194133252326316152
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@danjm danjm dismissed stale reviews from FrederikBolding and themself via 715834c December 4, 2024 20:02
@danjm danjm enabled auto-merge December 4, 2024 20:03
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danjm danjm added this pull request to the merge queue Dec 4, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [715834c]
Page Load Metrics (1773 ± 64 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15492106177213465
domContentLoaded15422088175113364
load15602112177313364
domInteractive23184393517
backgroundConnect106623157
firstReactRender14321642
getState712291232814
initialActions01000
loadScripts11301685135313263
setupStore66712147
uiStartup17602546204219694
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@Gudahtt Gudahtt merged commit b1e173a into main Dec 4, 2024
75 checks passed
@Gudahtt Gudahtt deleted the mikesposito/force-solana-version branch December 4, 2024 21:05
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
@metamaskbot metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.0 Issue or pull request that will be included in release 12.10.0 team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants