chore: change ownership of profile sync from notifications to identity #28901

mathieuartu · 2024-12-03T20:56:06Z

Description

This PR takes care of all the necessary changes in order to decouple "Profile Sync" from the notifications feature.
This also underlines the ownership change from @MetaMask/notifications to @MetaMask/identity.

The changes made here will help transitioning to cleaner separation of concerns for features leveraging profile sync (i.e Notifications, Account syncing...).

⚠️ This PR does not add missing tests nor introduces any changes. This is only moving files around and separating concerns.

Related issues

Fixes #28900

Manual testing steps

No testing steps since this PR does not change the implementation of existing features.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-12-03T20:56:21Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-12-04T07:36:02Z

Builds ready [cc0fb07]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2187 ± 188 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	451	2854	1978	613	294
		domContentLoaded	1488	2835	2172	388	186
		load	1503	2844	2187	391	188
		domInteractive	24	146	48	29	14
		backgroundConnect	8	59	20	15	7
		firstReactRender	15	69	23	12	6
		getState	114	319	158	43	21
		initialActions	0	1	0	0	0
		loadScripts	1063	2290	1673	321	154
		setupStore	7	36	10	6	3
		uiStartup	1743	3268	2550	467	224

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -1.22 KiB (-0.02%)
common: 0 Bytes (0.00%)

.github/CODEOWNERS

metamaskbot · 2024-12-04T12:57:33Z

Builds ready [a98eb8a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2042 ± 148 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	408	2328	1742	559	268
		domContentLoaded	1659	2931	2016	308	148
		load	1668	2958	2042	308	148
		domInteractive	25	95	43	20	10
		backgroundConnect	8	73	28	21	10
		firstReactRender	15	95	25	18	8
		getState	113	283	158	40	19
		initialActions	0	1	0	0	0
		loadScripts	1239	2360	1552	264	127
		setupStore	7	76	17	20	10
		uiStartup	1883	3416	2404	377	181

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -1.22 KiB (-0.02%)
common: 0 Bytes (0.00%)

Prithpal-Sooriya

LGTM from notifications side.

.github/CODEOWNERS

Co-authored-by: Mark Stacey <[email protected]>

metamaskbot · 2024-12-04T14:34:50Z

Builds ready [a1d6c08]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2137 ± 80 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	250	2348	1858	659	317
		domContentLoaded	1842	2420	2093	170	82
		load	1866	2434	2137	167	80
		domInteractive	26	67	38	11	5
		backgroundConnect	9	163	42	36	17
		firstReactRender	17	29	22	3	2
		getState	126	176	149	11	5
		initialActions	0	1	0	0	0
		loadScripts	1383	1863	1622	157	75
		setupStore	7	23	10	4	2
		uiStartup	2160	2741	2464	182	87

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -1.22 KiB (-0.02%)
common: 0 Bytes (0.00%)

danjm

I am approving the codeowner file changes, and assume the other reviews cover the other file changes

metamaskbot · 2024-12-04T19:13:47Z

Builds ready [f5c9fb9]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1797 ± 55 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1612	2211	1800	129	62
		domContentLoaded	1584	2100	1774	110	53
		load	1621	2128	1797	114	55
		domInteractive	24	46	30	6	3
		backgroundConnect	11	92	25	19	9
		firstReactRender	15	26	18	3	1
		getState	112	306	143	39	19
		initialActions	0	1	0	0	0
		loadScripts	1166	1647	1345	102	49
		setupStore	7	16	9	2	1
		uiStartup	1862	2663	2103	200	96

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -1.22 KiB (-0.02%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-12-04T21:55:08Z

Builds ready [f2918f0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2071 ± 121 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1720	2571	2073	266	128
		domContentLoaded	1698	2471	2029	241	116
		load	1720	2548	2071	253	121
		domInteractive	26	62	36	10	5
		backgroundConnect	9	95	41	25	12
		firstReactRender	16	110	31	26	13
		getState	85	399	164	69	33
		initialActions	0	1	0	0	0
		loadScripts	1267	1918	1563	223	107
		setupStore	7	74	13	14	7
		uiStartup	2058	3518	2463	405	194

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -1.22 KiB (-0.02%)
common: 0 Bytes (0.00%)

mathieuartu added 2 commits December 3, 2024 21:46

chore: change ownership of profile sync from notifications to identity

8e4c888

chore: update CODEOWNERS

fcffeb0

mathieuartu added the team-identity label Dec 3, 2024

mathieuartu self-assigned this Dec 3, 2024

mathieuartu added 2 commits December 3, 2024 22:06

fix: test

f8d4e70

fix: test

cc0fb07

mathieuartu commented Dec 4, 2024

View reviewed changes

.github/CODEOWNERS Show resolved Hide resolved

mathieuartu marked this pull request as ready for review December 4, 2024 08:17

mathieuartu requested review from a team as code owners December 4, 2024 08:17

Merge branch 'main' into chore/change_profile_sync_ownership

a98eb8a

mirceanis previously approved these changes Dec 4, 2024

View reviewed changes

Prithpal-Sooriya previously approved these changes Dec 4, 2024

View reviewed changes

Gudahtt reviewed Dec 4, 2024

View reviewed changes

.github/CODEOWNERS Outdated Show resolved Hide resolved

Update .github/CODEOWNERS

a1d6c08

Co-authored-by: Mark Stacey <[email protected]>

mathieuartu dismissed stale reviews from Prithpal-Sooriya and mirceanis via a1d6c08 December 4, 2024 14:01

Prithpal-Sooriya approved these changes Dec 4, 2024

View reviewed changes

NidhiKJha approved these changes Dec 4, 2024

View reviewed changes

mathieuartu enabled auto-merge December 4, 2024 16:21

danjm approved these changes Dec 4, 2024

View reviewed changes

mathieuartu disabled auto-merge December 4, 2024 16:45

Merge branch 'main' into chore/change_profile_sync_ownership

f5c9fb9

mathieuartu enabled auto-merge December 4, 2024 18:43

Merge branch 'main' into chore/change_profile_sync_ownership

f2918f0

mathieuartu added this pull request to the merge queue Dec 4, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024

mathieuartu added this pull request to the merge queue Dec 4, 2024

Merged via the queue into main with commit 79de169 Dec 4, 2024
75 checks passed

mathieuartu deleted the chore/change_profile_sync_ownership branch December 4, 2024 22:23

github-actions bot locked and limited conversation to collaborators Dec 4, 2024

metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: change ownership of profile sync from notifications to identity #28901

chore: change ownership of profile sync from notifications to identity #28901

mathieuartu commented Dec 3, 2024 •

edited

Loading

github-actions bot commented Dec 3, 2024

metamaskbot commented Dec 4, 2024

metamaskbot commented Dec 4, 2024

Prithpal-Sooriya left a comment

metamaskbot commented Dec 4, 2024

danjm left a comment

metamaskbot commented Dec 4, 2024

metamaskbot commented Dec 4, 2024

chore: change ownership of profile sync from notifications to identity #28901

chore: change ownership of profile sync from notifications to identity #28901

Conversation

mathieuartu commented Dec 3, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Dec 3, 2024

metamaskbot commented Dec 4, 2024

metamaskbot commented Dec 4, 2024

Prithpal-Sooriya left a comment

Choose a reason for hiding this comment

metamaskbot commented Dec 4, 2024

danjm left a comment

Choose a reason for hiding this comment

metamaskbot commented Dec 4, 2024

metamaskbot commented Dec 4, 2024

mathieuartu commented Dec 3, 2024 •

edited

Loading