Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize helper methods for signature e2e #28810

Merged
merged 8 commits into from
Dec 2, 2024
Merged

fix: optimize helper methods for signature e2e #28810

merged 8 commits into from
Dec 2, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Nov 29, 2024

Description

Signature e2e are slower after this PR is merged: #28423. This PR optimises those signature methods.

Related issues

Fixes: #28809

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Nov 29, 2024
@jpuri jpuri changed the title update fix: optimize helper method for signature e2e Nov 29, 2024
@jpuri jpuri requested review from seaona and chloeYue November 29, 2024 15:09
@jpuri jpuri marked this pull request as ready for review November 29, 2024 15:33
@jpuri jpuri requested a review from a team as a code owner November 29, 2024 15:33
@jpuri jpuri changed the title fix: optimize helper method for signature e2e fix: optimize helper methods for signature e2e Nov 29, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [b2cfd06]
Page Load Metrics (1681 ± 66 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32520481624327157
domContentLoaded14932026166613565
load15022049168113766
domInteractive24145372713
backgroundConnect85117136
firstReactRender148227199
getState45161832713
initialActions00000
loadScripts11071584126012761
setupStore66011126
uiStartup17502583192019996
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@@ -31,7 +31,6 @@ import {
} from './signature-helpers';

describe('Confirmation Signature - SIWE @no-mmi', function (this: Suite) {
this.timeout(200000); // This test is very long, so we need an unusually high timeout
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fix by @seaona to fix develop branch CI #28801

@metamaskbot
Copy link
Collaborator

Builds ready [234139f]
Page Load Metrics (1806 ± 138 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint155128041805286138
domContentLoaded151027401775279134
load154928071806287138
domInteractive24207534421
backgroundConnect867322010
firstReactRender145821126
getState45187793316
initialActions01000
loadScripts112522101344247119
setupStore643984
uiStartup177430092046292140
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit 93e480c Dec 2, 2024
75 checks passed
@jpuri jpuri deleted the temp_sig_fix branch December 2, 2024 15:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
@metamaskbot metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.0 Issue or pull request that will be included in release 12.10.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] SIWE test takes > 80 seconds to finish
4 participants