-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Reduce MMI trigger machine size #28689
Merged
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [57fb6c9]
Page Load Metrics (1988 ± 90 ms)
Bundle size diffs
|
hjetpoluru
approved these changes
Dec 2, 2024
The `check-mmi-trigger` job was using a medium machine, but the work performed during this job is trivial and doesn't require a medium machine. It has been reduced to small.
Gudahtt
force-pushed
the
reduce-mmi-trigger-machine-size
branch
from
December 2, 2024 14:20
57fb6c9
to
3b271d4
Compare
FrederikBolding
approved these changes
Dec 2, 2024
danjm
approved these changes
Dec 2, 2024
Builds ready [3b271d4]
Page Load Metrics (1986 ± 108 ms)
|
metamaskbot
added
the
release-12.10.0
Issue or pull request that will be included in release 12.10.0
label
Dec 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.10.0
Issue or pull request that will be included in release 12.10.0
team-extension-platform
team-mmi
PRs from the MMI team
team-wallet-framework
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
check-mmi-trigger
job was using a medium machine, but the work performed during this job is trivial and doesn't require a medium machine. It has been reduced to small.Related issues
No related issue, just a minor CircleCI credit usage reduction.
Manual testing steps
See that the trigger MMI job still passes.
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist