Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reduce MMI trigger machine size #28689

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 25, 2024

Description

The check-mmi-trigger job was using a medium machine, but the work performed during this job is trivial and doesn't require a medium machine. It has been reduced to small.

Open in GitHub Codespaces

Related issues

No related issue, just a minor CircleCI credit usage reduction.

Manual testing steps

See that the trigger MMI job still passes.

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt Gudahtt added team-extension-platform team-mmi PRs from the MMI team labels Nov 25, 2024
@Gudahtt Gudahtt marked this pull request as ready for review November 25, 2024 14:51
@Gudahtt Gudahtt requested review from kumavis and a team as code owners November 25, 2024 14:51
@metamaskbot
Copy link
Collaborator

Builds ready [57fb6c9]
Page Load Metrics (1988 ± 90 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33323581909409196
domContentLoaded17182276195618187
load17312368198818890
domInteractive234787410048
backgroundConnect9102402814
firstReactRender713951417335
getState471222211
initialActions01000
loadScripts12371795145915876
setupStore679182110
uiStartup190227482266237114
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@hjetpoluru hjetpoluru self-requested a review December 2, 2024 14:17
The `check-mmi-trigger` job was using a medium machine, but the work
performed during this job is trivial and doesn't require a medium
machine. It has been reduced to small.
@Gudahtt Gudahtt force-pushed the reduce-mmi-trigger-machine-size branch from 57fb6c9 to 3b271d4 Compare December 2, 2024 14:20
@Gudahtt Gudahtt enabled auto-merge December 2, 2024 14:36
@Gudahtt Gudahtt added this pull request to the merge queue Dec 2, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [3b271d4]
Page Load Metrics (1986 ± 108 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint166827161986225108
domContentLoaded166126901966220106
load167927201986224108
domInteractive266136105
backgroundConnect97323168
firstReactRender169627199
getState482591053818
initialActions00000
loadScripts12532111149218187
setupStore65210105
uiStartup189831322272294141

Merged via the queue into main with commit ca64247 Dec 2, 2024
75 checks passed
@Gudahtt Gudahtt deleted the reduce-mmi-trigger-machine-size branch December 2, 2024 15:05
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
@metamaskbot metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.0 Issue or pull request that will be included in release 12.10.0 team-extension-platform team-mmi PRs from the MMI team team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants