test: migrate signature redesign tests to page object model #28538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
pnarayanaswamy
changed the title
Builds ready [b7dc11a]
Page Load Metrics (1981 ± 105 ms)
Bundle size diffs
|
Builds ready [ff7afb9]
Page Load Metrics (1930 ± 233 ms)
Bundle size diffs
|
| ); | ||
|
|
||
| // await driver.waitUntilXWindowHandles(2); | ||
| // await driver.switchToWindowWithTitle(WINDOW_TITLES.TestDApp); |
There was a problem hiding this comment.
Remove commented out code?
digiwand
reviewed
Nov 25, 2024
| text: '0x581c3...45947', | ||
| }; | ||
|
|
||
| private nftTitle = { text: 'Withdrawal request' }; |
There was a problem hiding this comment.
[suggestion/non-blocker]: rather than private vars here, we could keep them outside of the class as a map structure. This would provide a quick lookup and instantiating a single object
e.g.
const SELECTOR = {
nft: { text: 'Withdrawal request' },
nftContractPetName: {
css: '.name__value',
text: '0x581c3...45947',
}
}
export default class PermitConfirmation extends Confirmation {
// ..
.. await this.driver.findElement(SELECTOR.nft);
There was a problem hiding this comment.
That's a good idea. But maybe best to do it out of the scope of this PR as there are already many pages using the current pattern for now. I'd also like to run it by the extension team.
pedronfigueiredo
previously approved these changes
Nov 26, 2024
Builds ready [81b6437]
Page Load Metrics (1705 ± 74 ms)
Bundle size diffs
|
Builds ready [3070f53]
Page Load Metrics (1625 ± 46 ms)
Bundle size diffs
|
digiwand
approved these changes
Nov 27, 2024
pedronfigueiredo
approved these changes
Nov 27, 2024
metamaskbot
added
the
release-12.9.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates the existing signature redesign e2e tests to use page object model.
Adds the relevant pages and updates the tests using the newly created pages.
Related issues
Fixes: #28540
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist