Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky anti-pattern getText + assert 2 #28043

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Oct 23, 2024

Description

Continuing the work of removing the e2e anti-pattern of finding the element and then asserting its text.
There are more occurrences, but this work is split in several PRs, for an easy review and a faster ci.
Once all occurrences have been fixed, we'll be able to merge @HowardBraham 's PR for adding a lint rule which prevents introducing it again.

Open in GitHub Codespaces

Related issues

Fixes: (but doesn't yet closes) #19870

Manual testing steps

  1. Check ci

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@seaona seaona self-assigned this Oct 23, 2024
@seaona seaona added flaky tests area-qa Relating to QA work (Quality Assurance) labels Oct 23, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona marked this pull request as ready for review October 23, 2024 14:45
@seaona seaona requested a review from a team as a code owner October 23, 2024 14:45
@metamaskbot
Copy link
Collaborator

Builds ready [1e12317]
Page Load Metrics (1992 ± 105 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint176127252001209100
domContentLoaded17122705195320397
load172427261992219105
domInteractive19118492512
backgroundConnect8175404120
firstReactRender552071083617
getState459222110
initialActions01000
loadScripts12632193146619292
setupStore1184392612
uiStartup191629762255269129
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-qa Relating to QA work (Quality Assurance) flaky tests team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants