fix: flaky anti-pattern getText + assert
#28041
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| await driver.findElement({ | ||
| xpath: | ||
| "//div[@data-testid='useSafeChainsListValidation']//label[contains(@class, 'toggle-button') and contains(@class, 'toggle-button--on')]", | ||
| }); |
There was a problem hiding this comment.
we need to use an xpath here since there's a long list of toggles, without a way of differentiating to which feature belong to
Builds ready [4cfcca0]
Page Load Metrics (2080 ± 140 ms)
Bundle size diffs
|
There was a problem hiding this comment.
I think we could update this one in incremental-security.spec.js.
const outerSegment = await driver.findElement(
'.qr-code__address-segments',
);
const publicAddress = await outerSegment.getText();
| @@ -13,7 +12,7 @@ const FixtureBuilder = require('../../fixture-builder'); | |||
| describe('Sign in with ethereum', function () { | |||
| it('user should be able to confirm sign in with ethereum', async function () { | |||
| const expectedSigninMessageTitle = | |||
| 'This site is requesting to sign in with Account 1'; | |||
| 'This site is requesting to sign in with'; | |||
| ); | ||
| await driver.waitForSelector({ | ||
| css: '#signTypedDataV4VerifyResult', | ||
| text: KNOWN_PUBLIC_KEY_ADDRESSES[0].address.toLocaleLowerCase(), |
There was a problem hiding this comment.
minor nit: could we have this in variable and then pass the variable. Its ok if you dont make the change too.
let address = KNOWN_PUBLIC_KEY_ADDRESSES[0].address.toLocaleLowerCase()
| await driver.waitForSelector({ | ||
| tag: 'dd', | ||
| text: currencySYMBOL, | ||
| }); |
There was a problem hiding this comment.
Could you add a more specific data-testid for this element or make be some other approach?
The reason I mention this is - I changed the text for currencySYMBOL from ETH to ET, the test would not fail leading to false negatives.
I also checked for any other unique identifiers but there aren't any so we need to add one in the code.
There was a problem hiding this comment.
Update on my previous comment - I think changing the data-testid would work.
There was a problem hiding this comment.
I think we could update this one in incremental-security.spec.js.
const outerSegment = await driver.findElement(
'.qr-code__address-segments',
);
const publicAddress = await outerSegment.getText();
| @@ -109,12 +109,10 @@ describe('Incremental Security', function () { | |||
| await driver.switchToWindow(extension); | |||
|
|
|||
| // should have the correct amount of eth | |||
| let currencyDisplay = await driver.waitForSelector({ | |||
| await driver.waitForSelector({ | |||
There was a problem hiding this comment.
I think we need to come up with a different approach because this does not fail if the text is changed for waitForSelector, and it does fail with the previous assertion
There was a problem hiding this comment.
To my surprise this did not fail if the text was changed here
const backupReminder = await driver.findElements({
xpath:
"//div[contains(@class, 'home-notification__text') and contains(text(), 'Back up your Secret Recovery Phrase to keep your wallet and funds secure')]",
});
assert.equal(backupReminder.length, 1);
Description
Continuing the work of removing the e2e anti-pattern of finding the element and then asserting its text.
There are more occurrences, but this work is split in several PRs, for an easy review and a faster ci.
Once all occurrences have been fixed, we'll be able to merge @HowardBraham 's PR for adding a lint rule which prevents introducing it again.
Related issues
Fixes: (but doesn't yet closes) #19870
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist