-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update debugging sentry step 3 #28034
Open
Unik0rnMaggie
wants to merge
2
commits into
develop
Choose a base branch
from
docs-update-sentry-debugging-readme
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Unik0rnMaggie
changed the title
Docs:Update Debugging Sentry Step 3
docs: Update Debugging Sentry Step 3
Oct 23, 2024
Unik0rnMaggie
changed the title
docs: Update Debugging Sentry Step 3
docs: update debugging sentry step 3
Oct 23, 2024
Unik0rnMaggie
added
area-documentation
Issues relating to documentation, in the codebase and off.
team-extension-platform
labels
Oct 23, 2024
Builds ready [49a9a99]
Page Load Metrics (2689 ± 322 ms)
Bundle size diffs
|
Unik0rnMaggie
added
team-qa
QA team
and removed
team-extension-platform
team-qa
QA team
labels
Oct 23, 2024
seaona
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, congrats on your first PR 🔥
Builds ready [b05c56c]
Page Load Metrics (2139 ± 100 ms)
Bundle size diffs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the command
METAMASK_DEBUG=true
in the.metamaskrc
file and building locally withyarn dist
oryarn dist:mv2
MetaMask cannot be loaded on Chrome or Firefox.By updating Step 3 from
development/README.md
and usingMETAMASK_DEBUG=1
the issue is no longer present and the MetaMask extension is loading normally on Chrome and Firefox.Related issues
Fixes: Loading issues for MetaMask extension when using
METAMASK_DEBUG=true
and building locally withyarn dist
oryarn dist:mv2
Manual testing steps
METAMASK_DEBUG=1
in the.metamaskrc
fileyarn dist
oryarn dist:mv2
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist