Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: poll for bridge quotes #28029

Open
wants to merge 1 commit into
base: mb891-2-quote-request-params
Choose a base branch
from

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Oct 22, 2024

Description

Changes:

  • Import the polling controller package and update lavamoat
  • Modify the BridgeController to extend the StaticIntervalPollingController. This is needed for polling bridge-api quotes once a valid quote request has been entered by a user

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1448

Manual testing steps

  1. Set BRIDGE_USE_DEV_APIS=1 in .metamaskrc
  2. Open background network tab
  3. Request bridge quotes in the extension
  4. Verify that a getQuote request is made with the specified parameters

Screenshots/Recordings

Before

N/A

After

Screen.Recording.2024-10-21.at.4.39.47.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@micaelae micaelae changed the base branch from develop to mb891-2-quote-request-params October 22, 2024 22:45
@micaelae micaelae marked this pull request as ready for review October 23, 2024 00:21
@micaelae micaelae requested review from a team as code owners October 23, 2024 00:21
@metamaskbot
Copy link
Collaborator

Builds ready [9f1f4a4]
Page Load Metrics (2275 ± 100 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint43428942180452217
domContentLoaded189228232239208100
load194228812275209100
domInteractive18198583617
backgroundConnect882332613
firstReactRender643251406431
getState692352813
initialActions01000
loadScripts13161906163715173
setupStore1285322512
uiStartup218932642573283136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 20.39 KiB (0.46%)
  • ui: 1.2 KiB (0.02%)
  • common: -121 Bytes (-0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [9f1f4a4]
Page Load Metrics (2275 ± 100 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint43428942180452217
domContentLoaded189228232239208100
load194228812275209100
domInteractive18198583617
backgroundConnect882332613
firstReactRender643251406431
getState692352813
initialActions01000
loadScripts13161906163715173
setupStore1285322512
uiStartup218932642573283136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 20.39 KiB (0.46%)
  • ui: 1.2 KiB (0.02%)
  • common: -121 Bytes (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants