New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add a script to remove circular dependencies #28023

Draft

davidmurdoch wants to merge 1 commit into circles-003 from circles-script

+273 −0

Contributor

davidmurdoch commented Oct 22, 2024 •

edited by github-actions bot

Loading

DO NOT MERGE


          a WIP script to move imports around

d86752d

Contributor

github-actions bot commented Oct 22, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

davidmurdoch changed the base branch from develop to circles-003

October 22, 2024 20:03

Collaborator

metamaskbot commented Oct 22, 2024

Builds ready [d86752d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1877 ± 64 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	355	2264	1730	457	219
		domContentLoaded	1668	2247	1852	135	65
		load	1734	2269	1877	134	64
		domInteractive	32	129	52	23	11

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -110 Bytes (-0.00%)
ui: 512 Bytes (0.01%)
common: 4.43 KiB (0.06%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet