-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix Snaps usage of PhishingController #27817
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected] |
GuillaumeRx
approved these changes
Oct 14, 2024
Mrtenz
approved these changes
Oct 14, 2024
FrederikBolding
force-pushed
the
fb/fix-phishing-detect-with-snaps
branch
from
October 14, 2024 13:53
d5dd7b3
to
2b891cb
Compare
Quality Gate passedIssues Measures |
Builds ready [2b891cb]
Page Load Metrics (1928 ± 87 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
metamaskbot
added
the
release-12.7.0
Issue or pull request that will be included in release 12.7.0
label
Oct 14, 2024
gauthierpetetin
added
release-12.6.0
Issue or pull request that will be included in release 12.6.0
and removed
release-12.7.0
Issue or pull request that will be included in release 12.7.0
labels
Oct 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
INVALID-PR-TEMPLATE
PR's body doesn't match template
release-12.6.0
Issue or pull request that will be included in release 12.6.0
team-snaps-platform
Snaps Platform team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes two problems with Snaps usage of
PhishingController
. Following #25839 the PhishingController expects full URLs instead of hostnames as the input totestOrigin
. In that PR, the argument ofisOnPhishingList
was incorrectly changed. This PR also patches in some changes from thesnaps
repo that are currently blocked by a release: MetaMask/snaps#2835, MetaMask/snaps#2750Manual testing steps
eth-phishing-detect