-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove Storybook theme flex style #27783
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettbear
added
area-documentation
Issues relating to documentation, in the codebase and off.
team-design-system
All issues relating to design system in Extension
labels
Oct 10, 2024
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
georgewrmarshall
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
georgewrmarshall
changed the title
Fix: Remove Storybook theme flex style
fix: Remove Storybook theme flex style
Oct 10, 2024
Builds ready [c31911f]
Page Load Metrics (1798 ± 52 ms)
Bundle size diffs
|
darkwing
approved these changes
Oct 14, 2024
Quality Gate passedIssues Measures |
Builds ready [1f8c864]
Page Load Metrics (1861 ± 68 ms)
Bundle size diffs
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 15, 2024
13 tasks
metamaskbot
added
the
release-12.10.1
Issue or pull request that will be included in release 12.10.1
label
Dec 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-documentation
Issues relating to documentation, in the codebase and off.
release-12.10.1
Issue or pull request that will be included in release 12.10.1
team-design-system
All issues relating to design system in Extension
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I updated the wrapper of the Storybook to remove the flex layout, as seen in the provided before and after screenshots. The change simplifies the layout, which was previously managed with a flexbox that is no longer necessary.
This modification improves layout management for the
FormTextField
component examples. Both light and dark modes are supported, ensuring a consistent appearance across different themes.Related issues
None reported.
Manual testing steps
FormTextField
component.Screenshots/Recordings
Before
After
Screen.Recording.2024-10-10.at.3.53.24.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist