Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove Storybook theme flex style #27783

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

garrettbear
Copy link
Contributor

@garrettbear garrettbear commented Oct 10, 2024

Description

In this PR, I updated the wrapper of the Storybook to remove the flex layout, as seen in the provided before and after screenshots. The change simplifies the layout, which was previously managed with a flexbox that is no longer necessary.

This modification improves layout management for the FormTextField component examples. Both light and dark modes are supported, ensuring a consistent appearance across different themes.

Related issues

None reported.

Manual testing steps

  1. Open the Storybook interface.
  2. Navigate to the FormTextField component.
  3. Observe the layout in both light and dark themes.
  4. Verify that the form elements are correctly aligned and behave as expected.

Screenshots/Recordings

Before

Screenshot 2024-10-10 at 3 48 41 PM

After

Screenshot 2024-10-10 at 3 51 02 PM
Screen.Recording.2024-10-10.at.3.53.24.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g., pull and build the branch, run the app, and test the code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and/or screenshots.

@garrettbear garrettbear added area-documentation Issues relating to documentation, in the codebase and off. team-design-system All issues relating to design system in Extension labels Oct 10, 2024
@garrettbear garrettbear requested a review from a team as a code owner October 10, 2024 22:54
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgewrmarshall georgewrmarshall changed the title Fix: Remove Storybook theme flex style fix: Remove Storybook theme flex style Oct 10, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [c31911f]
Page Load Metrics (1798 ± 52 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16472101180010953
domContentLoaded16382050177410751
load16472097179810952
domInteractive217544157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

@metamaskbot
Copy link
Collaborator

Builds ready [1f8c864]
Page Load Metrics (1861 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16512162185914369
domContentLoaded16112082182413565
load16522162186114168
domInteractive16190583617
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@georgewrmarshall georgewrmarshall added this pull request to the merge queue Nov 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2024
@georgewrmarshall georgewrmarshall added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 5f8af0e Dec 11, 2024
78 checks passed
@georgewrmarshall georgewrmarshall deleted the fix/storybook-theme-flex-remove branch December 11, 2024 02:34
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
@metamaskbot metamaskbot added the release-12.10.1 Issue or pull request that will be included in release 12.10.1 label Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-documentation Issues relating to documentation, in the codebase and off. release-12.10.1 Issue or pull request that will be included in release 12.10.1 team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants