Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump profile-sync-controller to 0.9.7 #27749

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Oct 10, 2024

Description

This PR bumps @metamask/profile-sync-controller to version 0.9.7.
This version fixes an account sync bug where we would save imported accounts in user storage.

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/NOTIFY-1215

Manual testing steps

  1. Create a new SRP
  2. Add new accounts, rename some
  3. Uninstall extension and reinstall
  4. Import your previously created SRP
  5. All your previously created accounts and respective names should be there!

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mathieuartu mathieuartu added the team-notifications Notifications team label Oct 10, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Oct 10, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] network 0 1.11 MB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@metamaskbot
Copy link
Collaborator

Builds ready [6db93d2]
Page Load Metrics (1634 ± 82 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14982315163816981
domContentLoaded14872260161316378
load14952316163417182
domInteractive129241199
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 1.42 KiB (0.02%)

Copy link

sonarcloud bot commented Oct 10, 2024

@mathieuartu mathieuartu marked this pull request as ready for review October 10, 2024 10:56
@mathieuartu mathieuartu requested a review from a team as a code owner October 10, 2024 10:56
@mathieuartu mathieuartu added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [1fa67b0]
Page Load Metrics (2004 ± 85 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24222191712623299
domContentLoaded15812286198017886
load15902296200417785
domInteractive24100502010
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 1.42 KiB (0.02%)

@mathieuartu mathieuartu added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024
@mathieuartu mathieuartu added this pull request to the merge queue Oct 10, 2024
Merged via the queue into develop with commit 86525fd Oct 10, 2024
78 checks passed
@mathieuartu mathieuartu deleted the chore/bump_profile_sync_controller_version branch October 10, 2024 12:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Oct 21, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.6.0 on PR, as PR was added to branch 12.6.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants