feat: Enable gas included swaps #27427

dan437 · 2024-09-26T14:59:43Z

Description

Users who don't have enough ETH to pay for gas fees while swapping will be able to swap now if the gas fee can be taken from one of the tokens they are swapping. Smart transactions must be enabled for this.

Related issues

Manual testing steps

Important: updated backend services must be used for this.

Enable Smart Transactions in Advanced Settings
Have e.g. 0 ETH and 100 USDC
Fill in the swap form with USDC -> ETH
You will see that the Swap button is enabled now is there is a slightly different UI for it (see the screenshot section)

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-09-26T14:59:57Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-09-27T11:49:47Z

Builds ready [d43efe7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1774 ± 94 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1561	2388	1775	193	93
		domContentLoaded	1544	2338	1749	184	88
		load	1552	2391	1774	197	94
		domInteractive	26	76	43	15	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 2.72 KiB (0.04%)
common: 922 Bytes (0.01%)

metamaskbot · 2024-09-27T12:18:35Z

Builds ready [ab8a9fa]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1781 ± 75 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1573	2201	1784	154	74
		domContentLoaded	1554	2111	1734	133	64
		load	1573	2207	1781	156	75
		domInteractive	15	198	50	38	18

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 2.72 KiB (0.04%)
common: 922 Bytes (0.01%)

metamaskbot · 2024-09-27T13:18:50Z

Builds ready [cd431be]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2294 ± 207 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	264	2867	1980	743	357
		domContentLoaded	1639	3571	2250	433	208
		load	1645	3588	2294	431	207
		domInteractive	16	112	49	24	11

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 2.79 KiB (0.04%)
common: 922 Bytes (0.01%)

metamaskbot · 2024-09-30T12:22:22Z

Builds ready [f345436]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1789 ± 91 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1547	2167	1782	189	91
		domContentLoaded	1537	2110	1759	184	88
		load	1545	2127	1789	189	91
		domInteractive	23	83	41	17	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 2.8 KiB (0.04%)
common: 922 Bytes (0.01%)

app/_locales/en/messages.json

test/jest/mock-store.js

ui/pages/swaps/prepare-swap-page/review-quote.js

ui/store/actions.ts

metamaskbot · 2024-10-01T08:48:50Z

Builds ready [6aac2e8]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1838 ± 56 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1669	2116	1835	109	53
		domContentLoaded	1614	2107	1811	112	54
		load	1622	2119	1838	118	56
		domInteractive	16	74	42	15	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.19 KiB (0.04%)
common: 903 Bytes (0.01%)

metamaskbot · 2024-10-01T09:38:12Z

Builds ready [fe6b349]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1755 ± 77 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1568	2095	1757	164	79
		domContentLoaded	1554	2085	1717	158	76
		load	1569	2095	1755	161	77
		domInteractive	22	151	46	28	14

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.26 KiB (0.04%)
common: 856 Bytes (0.01%)

Renaming Update linting Update tests Add / update tests

Co-authored-by: Derek Brans <[email protected]>

Update address

ui/pages/swaps/prepare-swap-page/review-quote.test.js

test/jest/mock-store.js

ui/pages/swaps/prepare-swap-page/review-quote.test.js

ui/store/actions.ts

Co-authored-by: Derek Brans <[email protected]>

metamaskbot · 2024-10-01T13:26:15Z

Builds ready [23d01e9]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1636 ± 75 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	306	2152	1569	327	157
		domContentLoaded	1357	2078	1619	145	70
		load	1364	2161	1636	157	75
		domInteractive	15	195	37	38	18

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.18 KiB (0.04%)
common: 842 Bytes (0.01%)

sonarqubecloud · 2024-10-01T15:36:02Z

Quality Gate failed

Failed conditions
77.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

metamaskbot · 2024-10-01T15:56:45Z

Builds ready [1c02d9f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1815 ± 81 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	315	2512	1668	482	232
		domContentLoaded	1634	2257	1792	159	76
		load	1645	2342	1815	169	81
		domInteractive	26	63	38	9	4

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.18 KiB (0.04%)
common: 842 Bytes (0.01%)

dan437 added the team-transactions Transactions team label Sep 26, 2024

dan437 requested review from antonydenyer, dbrans and infiniteflower September 26, 2024 14:59

dan437 requested review from a team as code owners September 26, 2024 14:59

dan437 force-pushed the gas-included-swaps branch from 4595cf6 to d43efe7 Compare September 27, 2024 09:42

dan437 force-pushed the gas-included-swaps branch from ab8a9fa to cd431be Compare September 27, 2024 12:47

dan437 force-pushed the gas-included-swaps branch from cd431be to f345436 Compare September 30, 2024 11:51

dbrans reviewed Sep 30, 2024

View reviewed changes

dan437 force-pushed the gas-included-swaps branch 3 times, most recently from e770fef to adb2a14 Compare October 1, 2024 12:13

dan437 and others added 10 commits October 1, 2024 14:41

Add support for gas included swaps

1172a9c

Renaming Update linting Update tests Add / update tests

Enable the "Max" link for default token if STX is available

7d2029d

Update ui/pages/swaps/prepare-swap-page/review-quote.js

c948bc8

Co-authored-by: Derek Brans <[email protected]>

Update styles

0c4a09f

Tiny refactoring, adding comments

20261af

Update calculations for gasTokenFiatAmount

061f048

Move an asterisk outside of translation files

c5d9db8

Update the "ViewAllQuotesLink" mini-component

c6fd1f2

Use the "getUsedQuote" selector

c8b026f

Update tests

37bec0d

Update address

Small refactoring

23d01e9

dan437 force-pushed the gas-included-swaps branch from adb2a14 to 23d01e9 Compare October 1, 2024 12:41

dbrans reviewed Oct 1, 2024

View reviewed changes

ui/pages/swaps/prepare-swap-page/review-quote.test.js Show resolved Hide resolved

test/jest/mock-store.js Outdated Show resolved Hide resolved

ui/pages/swaps/prepare-swap-page/review-quote.test.js Outdated Show resolved Hide resolved

ui/store/actions.ts Outdated Show resolved Hide resolved

Update ui/store/actions.ts

362c1de

Co-authored-by: Derek Brans <[email protected]>

infiniteflower previously approved these changes Oct 1, 2024

View reviewed changes

Update tests, add a space before a footnote asterisk

017b5db

dan437 dismissed infiniteflower’s stale review via 017b5db October 1, 2024 15:05

Fix a lint issue

1c02d9f

infiniteflower self-requested a review October 1, 2024 15:40

infiniteflower approved these changes Oct 1, 2024

View reviewed changes

dbrans approved these changes Oct 1, 2024

View reviewed changes

dan437 merged commit facf905 into develop Oct 1, 2024
76 of 77 checks passed

dan437 deleted the gas-included-swaps branch October 1, 2024 16:03

github-actions bot locked and limited conversation to collaborators Oct 1, 2024

metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Oct 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Enable gas included swaps #27427

feat: Enable gas included swaps #27427

dan437 commented Sep 26, 2024 •

edited

Loading

github-actions bot commented Sep 26, 2024

metamaskbot commented Sep 27, 2024

metamaskbot commented Sep 27, 2024

metamaskbot commented Sep 27, 2024

metamaskbot commented Sep 30, 2024

metamaskbot commented Oct 1, 2024

metamaskbot commented Oct 1, 2024

metamaskbot commented Oct 1, 2024

sonarqubecloud bot commented Oct 1, 2024

metamaskbot commented Oct 1, 2024

feat: Enable gas included swaps #27427

feat: Enable gas included swaps #27427

Conversation

dan437 commented Sep 26, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 26, 2024

metamaskbot commented Sep 27, 2024

metamaskbot commented Sep 27, 2024

metamaskbot commented Sep 27, 2024

metamaskbot commented Sep 30, 2024

metamaskbot commented Oct 1, 2024

metamaskbot commented Oct 1, 2024

metamaskbot commented Oct 1, 2024

sonarqubecloud bot commented Oct 1, 2024

Quality Gate failed

metamaskbot commented Oct 1, 2024

dan437 commented Sep 26, 2024 •

edited

Loading