fix: issue with default nonce value being wrong when switching networks between transactions

[jpuri]

Description

When submitting transactions the transaction after network switch takes custom nonce of previous network.

Related issues

Fixes: #26979

Manual testing steps

1. Enable custom nonce
2. Create a confirmation (may or may not submit) and then switch network
3. Create new transaction
4. Ensure that nonce in new transaction is correct

Screenshots/Recordings

TODO

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [3a522b7]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2208 ± 324 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	237	4486	2047	911	437
		domContentLoaded	1665	4304	2185	663	318
		load	1669	4333	2208	676	324
		domInteractive	22	171	55	35	17

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 231 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[sleepytanya]

Build from #27297 (comment)

1. Submitted Linea transaction - nonce 69
2. Switched to Sepolia with the latest transaction nonce 320
3. Transaction on Sepolia created with the nonce 69 (same as on latest Linea tx)

lineaSepolia.mov

[matthewwalsh0]

Not needed now and not introduced by this PR, but perhaps a future refactor could be to remove the nonce from Redux completely and instead just store the custom nonce directly in the TransactionMeta, or let the TransactionController derive it if not specified.

[sonarcloud]

Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

[metamaskbot]

Builds ready [8aa0342]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1933 ± 123 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	277	2579	1857	447	215
		domContentLoaded	1613	2562	1902	260	125
		load	1628	2584	1933	255	123
		domInteractive	15	176	48	36	17

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 231 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [622bd6f]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2221 ± 216 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	219	3720	1941	794	381
		domContentLoaded	1621	3604	2192	455	218
		load	1647	3610	2221	450	216
		domInteractive	18	190	58	35	17

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 250 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[sleepytanya]

@jpuri

Fixed:

nonce.mov