Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Estimated fee in redesigned screens #27247

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Sep 18, 2024

Description

maxFeePerGas, maxPriorityFeePerGas and estimatedBaseFee are decimal values that should be converted before being used inside multiplyHexes and addHexes. estimatedBaseFee also needs to be converted to wei.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Old Flow

Screenshot 2024-09-18 at 13 40 13

Redesigned Flow

Screenshot 2024-09-18 at 13 39 49

After

Redesigned Flow

Screenshot 2024-09-18 at 13 37 13

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Sep 18, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Sep 18, 2024
@pedronfigueiredo pedronfigueiredo requested review from a team as code owners September 18, 2024 12:35
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pedronfigueiredo pedronfigueiredo force-pushed the pnf/fix-redesigned-gas-fees branch 2 times, most recently from c862835 to 99b6fd0 Compare September 18, 2024 12:54
@pedronfigueiredo pedronfigueiredo force-pushed the pnf/fix-redesigned-gas-fees branch from 99b6fd0 to 8fc7133 Compare September 18, 2024 13:02
Copy link

sonarcloud bot commented Sep 18, 2024

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.02%. Comparing base (1a6f212) to head (8fc7133).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #27247   +/-   ##
========================================
  Coverage    70.02%   70.02%           
========================================
  Files         1443     1443           
  Lines        50165    50165           
  Branches     14041    14041           
========================================
  Hits         35127    35127           
  Misses       15038    15038           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [8fc7133]
Page Load Metrics (1804 ± 92 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22221461623482231
domContentLoaded14402307177119493
load14482310180419192
domInteractive1390402110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 63 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo merged commit 313adea into develop Sep 18, 2024
78 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/fix-redesigned-gas-fees branch September 18, 2024 13:56
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 18, 2024
@metamaskbot metamaskbot added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants