-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Estimated fee in redesigned screens #27247
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
c862835
to
99b6fd0
Compare
99b6fd0
to
8fc7133
Compare
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #27247 +/- ##
========================================
Coverage 70.02% 70.02%
========================================
Files 1443 1443
Lines 50165 50165
Branches 14041 14041
========================================
Hits 35127 35127
Misses 15038 15038 ☔ View full report in Codecov by Sentry. |
Builds ready [8fc7133]
Page Load Metrics (1804 ± 92 ms)
Bundle size diffs
|
Description
maxFeePerGas
,maxPriorityFeePerGas
andestimatedBaseFee
are decimal values that should be converted before being used insidemultiplyHexes
andaddHexes
.estimatedBaseFee
also needs to be converted to wei.Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Old Flow
Redesigned Flow
After
Redesigned Flow
Pre-merge author checklist
Pre-merge reviewer checklist