Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating close icon svg #27235

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix: updating close icon svg #27235

merged 1 commit into from
Sep 18, 2024

Conversation

georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Sep 18, 2024

Description

This pull request updates the close icon SVG to match the design specifications. The existing SVG used in the code was inconsistent with the design provided by the design team, so this change replaces it with the correct version to ensure visual consistency across the application.

Open in GitHub Codespaces

Related issues

Fixes: #27234

Manual Testing Steps

  1. Navigate to any part of the application where the close icon is displayed.
  2. Verify that the close icon matches the design specification.
  3. Test the icon in various browsers (Chrome, Firefox, etc.) to ensure it displays correctly.
  4. Test on both light and dark modes (if applicable).
  5. Verify the close icon’s appearance in different screen sizes (desktop, tablet, mobile).

Screenshots/Recordings

Before

Screenshot 2024-09-17 at 7 45 29 PM Screenshot 2024-09-17 at 7 39 56 PM

After

Screenshot 2024-09-17 at 7 45 48 PM Screenshot 2024-09-17 at 7 40 13 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Sep 18, 2024
@georgewrmarshall georgewrmarshall self-assigned this Sep 18, 2024
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner September 18, 2024 02:46
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 18, 2024
Copy link

sonarcloud bot commented Sep 18, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [9150bdf]
Page Load Metrics (1630 ± 99 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint146123991626216104
domContentLoaded14522296160620196
load14702356163020699
domInteractive20181373517
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.02%. Comparing base (bc7929b) to head (9150bdf).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #27235   +/-   ##
========================================
  Coverage    70.02%   70.02%           
========================================
  Files         1443     1443           
  Lines        50164    50164           
  Branches     14039    14039           
========================================
  Hits         35126    35126           
  Misses       15038    15038           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgewrmarshall georgewrmarshall removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 18, 2024
@georgewrmarshall georgewrmarshall requested a review from a team September 18, 2024 15:44
@garrettbear garrettbear merged commit 832e6fc into develop Sep 18, 2024
91 checks passed
@garrettbear garrettbear deleted the fix/close-svg branch September 18, 2024 16:41
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 18, 2024
@metamaskbot metamaskbot added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 29, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Close Icon SVG to Match Design Specifications
4 participants