Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Q Mainnet symbol #26888 #27134

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix: Update Q Mainnet symbol #26888 #27134

merged 1 commit into from
Sep 23, 2024

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Sep 13, 2024

Description

Original PR: #26888

Note: we need to fix ci for allowing to run jobs in branches outside the MM repo, so this is just a temporary approach.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@seaona seaona requested a review from a team as a code owner September 13, 2024 13:29
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Sep 13, 2024

@seaona seaona changed the title fix: Update Q Mainnet symbol #26888 fix: Update Q Mainnet symbol #26888 Sep 13, 2024
@DDDDDanica DDDDDanica mentioned this pull request Sep 13, 2024
7 tasks
@KyrylR
Copy link

KyrylR commented Sep 19, 2024

Hi @seaona,

Are there any updates on this?

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.04%. Comparing base (fb72eca) to head (98144ca).
Report is 76 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #27134   +/-   ##
========================================
  Coverage    70.04%   70.04%           
========================================
  Files         1435     1435           
  Lines        49927    49927           
  Branches     13981    13981           
========================================
  Hits         34971    34971           
  Misses       14956    14956           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [98144ca]
Page Load Metrics (1656 ± 64 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint21519721600342164
domContentLoaded14681872163612058
load14751975165613364
domInteractive236636136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 3 Bytes (0.00%)

@seaona
Copy link
Contributor Author

seaona commented Sep 23, 2024

Are there any updates on this?

@KyrylR merging it right now 👍

@seaona seaona merged commit 0e8c551 into develop Sep 23, 2024
88 of 89 checks passed
@seaona seaona deleted the q-symbol-update branch September 23, 2024 16:33
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
@metamaskbot metamaskbot added release-12.6.0 Issue or pull request that will be included in release 12.6.0 release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants