fix: display of network name in network switch toast on confirmation pages

[jpuri]

Description

Fix display of network name on account switch toast, name of some less popular networks is not visible.

Related issues

Fixes: #26982

Manual testing steps

1. Open multiple DAPPs on different network, ensure one is Fantom network
2. Submit transaction for different dapps in quick succession
3. Ensure that when transaction is submitted from Fantom, network toast has correct network name

Screenshots/Recordings

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [4f4d14d]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1660 ± 52 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	207	1955	1593	334	161
		domContentLoaded	1487	1841	1635	91	44
		load	1497	1959	1660	107	52
		domInteractive	12	60	27	13	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0.00%)
• ui: -95 Bytes (-0.00%)
• common: 256 Bytes (0.00%)

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[metamaskbot]

Builds ready [6e559b0]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1603 ± 96 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1356	2156	1611	208	100
		domContentLoaded	1349	2018	1579	189	91
		load	1357	2067	1603	201	96
		domInteractive	12	54	27	9	4

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0.00%)
• ui: -95 Bytes (-0.00%)
• common: 256 Bytes (0.00%)

[codecov]

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.03%. Comparing base (daacc1a) to head (6e559b0).
Report is 4 commits behind head on develop.

Files with missing lines	Patch %	Lines
...twork-change-toast/network-change-toast-legacy.tsx	75.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #27100      +/-   ##
===========================================
+ Coverage    70.02%   70.03%   +0.01%     
===========================================
  Files         1432     1432              
  Lines        49872    49879       +7     
  Branches     13969    13970       +1     
===========================================
+ Hits         34922    34930       +8     
+ Misses       14950    14949       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sleepytanya]

@jpuri

[digiwand]

Nice fix!

Looks like the style is off with the toast. might be a DS toast specific issue. It should be absolute/relative from the footer, not fixed position from the display height

[metamaskbot]

Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut.