Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change default currency decimals for issue 26646 #27074

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Conversation

ejwessel
Copy link
Contributor

@ejwessel ejwessel commented Sep 11, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes:
#26646

Manual testing steps

  1. Select a token whose decimal() is 0 (ETH:0xaec2e87e0a235266d9c5adc9deb4b2e29b54d009)
  2. Click Send and fill in the acceptance address
  3. On the sending page, when filling in the sending amount, fill in a value less than the available balance or click the maximum button
  4. confirm that max is correctly displayed and no error appears when selecting a value less than the available balance.

Screenshots/Recordings

Before

After

Screenshot 2024-09-11 at 12 18 33 Screenshot 2024-09-11 at 12 18 37

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ejwessel ejwessel requested a review from a team as a code owner September 11, 2024 17:39
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ejwessel
Copy link
Contributor Author

Will make another bug for the send button balance equating to 0

jclancy93
jclancy93 previously approved these changes Sep 11, 2024
darkwing
darkwing previously approved these changes Sep 11, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [f27f091]
Page Load Metrics (1772 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24221071701372179
domContentLoaded15242066174715775
load15532111177216579
domInteractive136535147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 40 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

sonarcloud bot commented Sep 12, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [e1eda3f]
Page Load Metrics (1962 ± 141 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23827101771578277
domContentLoaded159626991941297143
load160827091962293141
domInteractive15183443718
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 40 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.12%. Comparing base (5053c3e) to head (e1eda3f).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
ui/components/app/currency-input/currency-input.js 66.67% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #27074      +/-   ##
===========================================
- Coverage    70.12%   70.12%   -0.00%     
===========================================
  Files         1426     1426              
  Lines        49705    49707       +2     
  Branches     13905    13906       +1     
===========================================
+ Hits         34853    34854       +1     
- Misses       14852    14853       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ejwessel ejwessel merged commit c7f4f43 into develop Sep 12, 2024
78 checks passed
@ejwessel ejwessel deleted the fix-issue-26646 branch September 12, 2024 16:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 12, 2024
@metamaskbot metamaskbot added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 29, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-bridge
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants