fix(action): add a workaround for known bots

[gauthierpetetin]

Description

Bots like "devin-ai-integration" are not Github users, which leads to the following error when the Github action is executed on PRs created by bots.

Same PR for Mobile repo.

This PR adds a workaround for known bots.

Related issues

Fixes: #27037

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• [] I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[georgewrmarshall]

LGTM! Thanks for the quick fix @gauthierpetetin 🙏 🔥

[georgewrmarshall]

Hmm looks like it's still failing. I got Devin AI to duplicate the updates here and create a new PR so I can use that to test #27040

[gauthierpetetin]

The error message in the test PR you prepared shows userBelongsToMetaMaskOrg function is being called.
I don't understand how this can happen. Given that labelable?.author equals "devin-ai-integration", we shall not be able to reach line 87 of this script.

[gauthierpetetin]

Hi @georgewrmarshall , I just tried it out on a test repo:

• Here's an issue I created BEFORE adding myself (@gauthierpetetin ) to the list of known bots => The Github action ran successfully and external-contributor label was added, which indicates userBelongsToMetaMaskOrg function was executed and returned false
• Here's another issue I created AFTER adding myself (@gauthierpetetin ) to the list of known bots (cf. this commit) => The Github action ran successfully and external-contributor label was not added, which indicates userBelongsToMetaMaskOrg function hasn't been executed (which is expected behaviour for knownBots)

[hjetpoluru]

LGTM

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.96%. Comparing base (aeb91c9) to head (76669a9).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #27019   +/-   ##
========================================
  Coverage    69.96%   69.96%           
========================================
  Files         1441     1441           
  Lines        50102    50102           
  Branches     14012    14012           
========================================
  Hits         35049    35049           
  Misses       15053    15053           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [76669a9]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1694 ± 103 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	217	2102	1573	422	203
		domContentLoaded	1415	2095	1673	213	102
		load	1424	2100	1694	214	103
		domInteractive	12	103	39	28	14

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[georgewrmarshall]

I was under the impression the actions were run from the PR and not from develop, which is why I expected the tests to pass in this duplicate PR that I had Devin create. Let's merge and test!