-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update scam token warning #26994
fix: Update scam token warning #26994
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
Builds ready [17e18a8]
Page Load Metrics (2010 ± 91 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Co-authored-by: legobeat <[email protected]>
Co-authored-by: legobeat <[email protected]>
Builds ready [cd931f8]
Page Load Metrics (1778 ± 127 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…om:MetaMask/metamask-extension into fix/mmassets-384_update-scam-token-warning
Builds ready [e43b0fc]
Page Load Metrics (1810 ± 118 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Builds ready [1307375]
Page Load Metrics (1800 ± 60 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!🟢
Quality Gate failedFailed conditions |
Builds ready [3bfabac]
Page Load Metrics (2126 ± 56 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This PR updates the scam warning to be less aggressive and to also include a suggested ticker symbol.
I also took the opportunity to remove the redundant MATIC chain collision check, which is no longer needed since the remote chain list has been updated upstream.
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-384
Manual testing steps
Add a custom network, with a custom/incorrect ticker (try adding Polygon with
MATIC
ticker)Scam warning on token list page should reflect new copy from ticket.
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist