Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update scam token warning #26994

Merged
merged 33 commits into from
Sep 24, 2024

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Sep 9, 2024

Description

This PR updates the scam warning to be less aggressive and to also include a suggested ticker symbol.

I also took the opportunity to remove the redundant MATIC chain collision check, which is no longer needed since the remote chain list has been updated upstream.

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-384

Manual testing steps

Add a custom network, with a custom/incorrect ticker (try adding Polygon with MATIC ticker)

Scam warning on token list page should reflect new copy from ticket.

Screenshots/Recordings

Screenshot 2024-09-09 at 11 17 17 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Sep 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish changed the title Fix/mmassets 384 update scam token warning fix: Update scam token warning Sep 9, 2024
Copy link

sonarcloud bot commented Sep 10, 2024

@gambinish gambinish marked this pull request as ready for review September 10, 2024 00:52
@gambinish gambinish requested review from a team as code owners September 10, 2024 00:52
@metamaskbot
Copy link
Collaborator

Builds ready [17e18a8]
Page Load Metrics (2010 ± 91 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17282453200120297
domContentLoaded17072435196418488
load17302439201019091
domInteractive22152583417
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 514 Bytes (0.01%)
  • common: 248 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [cd931f8]
Page Load Metrics (1778 ± 127 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint148826251781274131
domContentLoaded147625411758265127
load148525531778265127
domInteractive147940168
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 514 Bytes (0.01%)
  • common: 241 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [e43b0fc]
Page Load Metrics (1810 ± 118 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint159328291822254122
domContentLoaded157927991788249120
load158328041810246118
domInteractive26203543718
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 614 Bytes (0.01%)
  • common: 241 Bytes (0.00%)

@gambinish gambinish requested a review from darkwing September 21, 2024 00:54
legobeat
legobeat previously approved these changes Sep 21, 2024
Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legobeat legobeat requested a review from a team September 21, 2024 08:40
@metamaskbot
Copy link
Collaborator

Builds ready [1307375]
Page Load Metrics (1800 ± 60 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15882081180912861
domContentLoaded15772020177711555
load15892100180012460
domInteractive227748199
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 679 Bytes (0.01%)
  • common: 241 Bytes (0.00%)

Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!🟢

Copy link

sonarcloud bot commented Sep 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
78.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [3bfabac]
Page Load Metrics (2126 ± 56 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27722711848654314
domContentLoaded17832201209210551
load17932267212611756
domInteractive168147188
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 679 Bytes (0.01%)
  • common: 241 Bytes (0.00%)

@gambinish gambinish merged commit 83a6444 into develop Sep 24, 2024
76 of 77 checks passed
@gambinish gambinish deleted the fix/mmassets-384_update-scam-token-warning branch September 24, 2024 22:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2024
@metamaskbot metamaskbot added release-12.6.0 Issue or pull request that will be included in release 12.6.0 release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants