-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't show AccountListMenu back button by default #26940
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Pulled it down and tested it and it LGTM! Just need the type issue failing the linter resolved |
ui/components/multichain/account-list-menu/account-list-menu.tsx
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26940 +/- ##
===========================================
- Coverage 70.17% 70.17% -0.00%
===========================================
Files 1425 1425
Lines 49652 49651 -1
Branches 13890 13890
===========================================
- Hits 34842 34841 -1
Misses 14810 14810 ☔ View full report in Codecov by Sentry. |
Builds ready [48b77c8]
Page Load Metrics (1656 ± 85 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- Pulled branch checked accounts menu modal did not show back button ✅
@@ -25,7 +25,7 @@ export interface ModalHeaderProps extends HeaderBaseStyleUtilityProps { | |||
* The onClick handler for the back `ButtonIcon` | |||
* When passed this will allow for the back `ButtonIcon` to show | |||
*/ | |||
onBack?: () => void; | |||
onBack?: () => void | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking: Should both onBack
and onClose
props use the same type?
Description
A recent change (#26271) made it such that the "<" (back button) in the
AccountListMenu
component always shows. We do not want this when theAccountListMenu
first opens, so this PR ensures that.Related issues
Fixes:
Manual testing steps
AccountListMenu
<
<
<
, go back to main menuScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist