Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't show AccountListMenu back button by default #26940

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Sep 5, 2024

Description

A recent change (#26271) made it such that the "<" (back button) in the AccountListMenu component always shows. We do not want this when the AccountListMenu first opens, so this PR ensures that.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Open the AccountListMenu
  2. Don't see the <
  3. Click the "Add account" button
  4. See the <
  5. Click the <, go back to main menu

Screenshots/Recordings

Before

SCR-20240904-pens

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner September 5, 2024 14:59
@darkwing darkwing added team-wallet-ux needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward
Copy link
Contributor

Pulled it down and tested it and it LGTM! Just need the type issue failing the linter resolved

@darkwing darkwing requested a review from a team as a code owner September 5, 2024 18:08
@darkwing darkwing requested a review from a team as a code owner September 6, 2024 14:07
Copy link

sonarcloud bot commented Sep 6, 2024

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.17%. Comparing base (2f1f4d5) to head (48b77c8).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #26940      +/-   ##
===========================================
- Coverage    70.17%   70.17%   -0.00%     
===========================================
  Files         1425     1425              
  Lines        49652    49651       -1     
  Branches     13890    13890              
===========================================
- Hits         34842    34841       -1     
  Misses       14810    14810              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [48b77c8]
Page Load Metrics (1656 ± 85 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22321151376591284
domContentLoaded14312105163917383
load14392114165617785
domInteractive1291332010
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -7 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Pulled branch checked accounts menu modal did not show back button ✅

@@ -25,7 +25,7 @@ export interface ModalHeaderProps extends HeaderBaseStyleUtilityProps {
* The onClick handler for the back `ButtonIcon`
* When passed this will allow for the back `ButtonIcon` to show
*/
onBack?: () => void;
onBack?: () => void | undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking: Should both onBack and onClose props use the same type?

@georgewrmarshall georgewrmarshall merged commit 1e3d50a into develop Sep 9, 2024
78 checks passed
@georgewrmarshall georgewrmarshall deleted the accountlistmenu-back-button branch September 9, 2024 16:47
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 9, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants