Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updating @metamask/eth-json-rpc-middleware to version 14.0.1 to fix regression in typed sign requests #26914

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 4, 2024

Description

Type sign signature requests break if verifyingContract is not defined.

Related issues

Ref: #26908

Manual testing steps

  1. Connect to a dapp
  2. Ensure that Ethereum Mainnet is the selected chain for that dapp
  3. Run this in the console:
await window.ethereum.request({
  method: 'eth_signTypedData_v4',
  params: [
    window.ethereum.selectedAddress,
     `{"types":{"EIP712Domain":[{"name":"name","type":"string"},{"name":"version","type":"string"},{"name":"chainId","type":"uint256"}],"Permit":[{"name":"owner","type":"address"},{"name":"spender","type":"address"},{"name":"value","type":"uint256"},{"name":"nonce","type":"uint256"},{"name":"deadline","type":"uint256"}]},"primaryType":"Permit","domain":{"name":"USD Coin","chainId":${1},"version":"2"},"message":{"owner":"${window.ethereum.selectedAddress}","spender":"0x1661F1B207629e4F385DA89cFF535C8E5Eb23Ee3","value":"1033366316628","nonce":1,"deadline":1678709555}}`,
  ],
})

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Sep 4, 2024
@jpuri jpuri requested a review from a team as a code owner September 4, 2024 18:02
Copy link
Contributor

github-actions bot commented Sep 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] network 0 156 kB gudahtt

🚮 Removed packages: npm/@metamask/[email protected])

View full report↗︎

Copy link

sonarcloud bot commented Sep 4, 2024

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jpuri jpuri merged commit eb4066e into develop Sep 4, 2024
83 of 84 checks passed
@jpuri jpuri deleted the middleware_update branch September 4, 2024 18:26
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 4, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [237617a]
Page Load Metrics (1602 ± 96 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13432176160120197
domContentLoaded13362157158920196
load13432177160220196
domInteractive125128105
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 6 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants