-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move porfolio button next to price amount #26867
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jonybur so sorry, we have a new change request while you still have this PR open; We'd also want to change the order of the buttons. I'll be able to confirm this most likely tomorrow. The order would be: Buy/Sell |
I've also updated the designs in figma with this new ordering |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26867 +/- ##
===========================================
+ Coverage 70.12% 70.14% +0.01%
===========================================
Files 1422 1424 +2
Lines 49526 49572 +46
Branches 13863 13868 +5
===========================================
+ Hits 34730 34769 +39
- Misses 14796 14803 +7 ☔ View full report in Codecov by Sentry. |
Builds ready [b6fdfce]
Page Load Metrics (1816 ± 94 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Moves the portfolio button so that it's next to the token price amount.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3201
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist