Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change copy from estimated to network fee #26859

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Sep 3, 2024

Description

Update copy and corresponding tests.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3063

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Sep 3, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Sep 3, 2024
@pedronfigueiredo pedronfigueiredo requested review from a team as code owners September 3, 2024 13:55
Copy link
Contributor

github-actions bot commented Sep 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pedronfigueiredo pedronfigueiredo changed the title Change copy from estimated to network fee feat: Change copy from estimated to network fee Sep 3, 2024
Copy link

sonarcloud bot commented Sep 3, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [0ae5a93]
Page Load Metrics (1876 ± 103 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint21322721715498239
domContentLoaded158323051850213102
load160823101876215103
domInteractive126831126
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -2 Bytes (-0.00%)
  • common: 35 Bytes (0.00%)

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13%. Comparing base (594d580) to head (0ae5a93).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #26859      +/-   ##
===========================================
- Coverage    70.13%   70.13%   -0.00%     
===========================================
  Files         1424     1424              
  Lines        49571    49571              
  Branches     13867    13867              
===========================================
- Hits         34765    34764       -1     
- Misses       14806    14807       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedronfigueiredo pedronfigueiredo merged commit 3e68e38 into develop Sep 4, 2024
78 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/3063 branch September 4, 2024 10:04
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 4, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants