Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Swaps UI should show POL not MATIC #26827

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Aug 30, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gambinish gambinish changed the title Swaps UI should show POL not MATIC fix: Swaps UI should show POL not MATIC Aug 30, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish requested a review from Gudahtt August 30, 2024 19:40
@gambinish gambinish marked this pull request as ready for review August 30, 2024 19:40
@gambinish gambinish requested a review from a team as a code owner August 30, 2024 19:40
@@ -70,8 +70,8 @@ export const BNB_SWAPS_TOKEN_OBJECT: SwapsTokenObject = {
} as const;

export const MATIC_SWAPS_TOKEN_OBJECT: SwapsTokenObject = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can re-name this variable too in a follow-up PR (no need to back port the rename though)

@Gudahtt
Copy link
Member

Gudahtt commented Aug 30, 2024

I tested this and was able to fetch quotes for both MATIC and POL. Both still appear in the list.

Edit: Oh, the MATIC entry is probably the Ethereum token contract. Hmm.

Edit2: Confirmed, only POL is showing as the native currency on Polygon, but MATIC and POL contracts are available for swaps on Ethereum Mainnnet. Working as expected.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 00ebb93 into Version-v12.1.1 Aug 30, 2024
73 of 74 checks passed
@Gudahtt Gudahtt deleted the fix/matic-pol-swap-ui branch August 30, 2024 20:23
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [bbf21a1]
Page Load Metrics (172 ± 187 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint751671222613
domContentLoaded117831209
load411870172390187
domInteractive117831209

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants