-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Swaps UI should show POL not MATIC #26827
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@@ -70,8 +70,8 @@ export const BNB_SWAPS_TOKEN_OBJECT: SwapsTokenObject = { | |||
} as const; | |||
|
|||
export const MATIC_SWAPS_TOKEN_OBJECT: SwapsTokenObject = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can re-name this variable too in a follow-up PR (no need to back port the rename though)
I tested this and was able to fetch quotes for both MATIC and POL. Both still appear in the list. Edit: Oh, the MATIC entry is probably the Ethereum token contract. Hmm. Edit2: Confirmed, only POL is showing as the native currency on Polygon, but MATIC and POL contracts are available for swaps on Ethereum Mainnnet. Working as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [bbf21a1]
Page Load Metrics (172 ± 187 ms)
|
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist