fix(cherry-pick): remove BTC accounts from send flow (#26271) #26821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support of testnet account within the extension following the same pattern than for mainnet accounts with a feature flag. [](https://codespaces.new/MetaMask/metamask-extension/pull/25772?quickstart=1) Fixes: **MetaMask/accounts-planning#511 1. Run `yarn start:flask` 2. Go to the experimental settings tab 3. Enable the "Bitcoin testnet support" toggle 4. Click on the account menu list (on top) 5. You should now see a "Add a new Bitcoin account (Testnet)" 6. Click this button and follow the flow 7. You should now see a testnet account (starting with `tb1q...`) https://github.com/MetaMask/metamask-extension/assets/569258/b59b9fc5-dc85-4b5f-87be-38e42256b243 - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Daniel Rocha <[email protected]>
This state has been moved from the initial file, so we had to report it back in the new file, otherwise tests will diff and fail.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR removes BTC accounts from the account picker and `Your Accounts` list in the send flow. [](https://codespaces.new/MetaMask/metamask-extension/pull/26271?quickstart=1) Fixes: MetaMask/accounts-planning#546 1. Create btc account 2. Select an evm account 3. Click send 4. See that the BTC account is not available in `Your Accounts` 5. Click the account picker and see that the BTC account is not available. <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] -->   <!-- [screenshots/recordings] -->   - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Charly Chevalier <[email protected]>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
gantunesr
changed the title
gantunesr
changed the title
gantunesr
changed the title
owencraston
approved these changes
Aug 30, 2024
Builds ready [5fad458]
Page Load Metrics (419 ± 332 ms)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## Version-v12.2.0 #26821 +/- ##
===================================================
+ Coverage 70.40% 70.41% +0.01%
===================================================
Files 1399 1399
Lines 49457 49471 +14
Branches 13587 13589 +2
===================================================
+ Hits 34817 34833 +16
+ Misses 14640 14638 -2 ☔ View full report in Codecov by Sentry. |
ccharly
deleted the
v12.2.0-cherrypick-remove-btc-accounts-from-send-page
branch
](https://codespaces.new/MetaMask/metamask-extension/pull/25772?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/26271?quickstart=1){kind=link}
metamaskbot
added
the
release-12.2.0
|
No release label on PR. Adding release label release-12.2.0 on PR, as PR was cherry-picked in branch 12.2.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cherry-picks the commit fbd1ea1 into the RC v12.2.0
Related issues
Fixes: NA
Manual testing steps
Refer to #26271
Screenshots/Recordings
Refer to #26271
Pre-merge author checklist
Pre-merge reviewer checklist