-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: preload _locales/en/messages.json
so we don't have to wait as long for our JS to dynamically load it
#26556
Conversation
… long for our JS to dynamically load it
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
Builds ready [369b1f5]
Page Load Metrics (84 ± 15 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26556 +/- ##
===========================================
+ Coverage 69.96% 70.01% +0.04%
===========================================
Files 1405 1405
Lines 48996 49029 +33
Branches 13697 13706 +9
===========================================
+ Hits 34280 34325 +45
+ Misses 14716 14704 -12 ☔ View full report in Codecov by Sentry. |
Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut. |
We always load the English version of
messages.json
. This PR makes use of linkrel=preload
so that the browser will get the file ready for use immediately -- well before our JavaScript file that will eventually need it asks for it. This reduces the amount of waiting due to Network Waterfall (even if the network is the local file system).