fix: name being out of sync in account list

[montelaidev]

Description

This PR fixes the issue where the account name being created in the connect account flow is out of sync.

Related issues

Fixes: 25846

Manual testing steps

1. Create a snap/hw account
2. Go to test dapp
3. Click connect
4. Click on create new account
5. See that the suggested name is Account 3
6. Create the new account
7. See in the list that there is Account 3 in the list

Screenshots/Recordings

Before

Screen.Recording.2024-08-20.at.22.32.22.mov

After

Screen.Recording.2024-08-20.at.22.29.50.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[gantunesr]

Screen.Recording.2024-08-20.at.10.47.19.AM.mov

[metamaskbot]

Builds ready [b68c4da]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (75 ± 12 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	69	256	108	40	19
		domContentLoaded	43	161	72	25	12
		load	50	161	75	24	12
		domInteractive	10	56	27	12	6

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: -507 Bytes (-0.01%)
• common: 0 Bytes (0.00%)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.02%. Comparing base (dd4c2b4) to head (b68c4da).
Report is 6 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #26542      +/-   ##
===========================================
+ Coverage    69.96%   70.02%   +0.06%     
===========================================
  Files         1405     1405              
  Lines        48996    49006      +10     
  Branches     13697    13703       +6     
===========================================
+ Hits         34280    34316      +36     
+ Misses       14716    14690      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Missing release label release-12.2.0 on PR. Adding release label release-12.2.0 on PR and removing other release labels(release-12.5.0), as PR was cherry-picked in branch 12.2.0.