fix: Fix migration 120.3 error caused by invalid state

[Gudahtt]

Description

For a small number of users, migration 120.3 is failing due to invalid TransactionController.transactions state. We aren't sure yet how this is happening, but we can resolve the problem by updating the migration to delete this invalid state if we detect it. No other state relies on this state, and if it's invalid it won't work properly anyway.

The migration has been renamed from 120.3 to 120.6 so that it will be re-run for any users who encountered this migration on v12.0.1 already.

Related issues

Fixes #26423

Manual testing steps

• Create a dev build from v12.0.0
• Install the dev build from the dist/chrome directory and proceed through onboarding
• Run this command in the background console:

  chrome.storage.local.get(
    null,
    (state) => {
      state.data.TransactionController.transactions = {};
      chrome.storage.local.set(state, () => chrome.runtime.reload());
    }
  );
  

• Disable the extension
• Switch to v12.0.1 and create a dev build
• Enable and reload the extension
  • You should see in the console that migration 120.3 has failed
• Disable the extension
• Switch to this branch and create a dev build
• Enable and reload the extension
  • You should see in the console that migration 120.6 has run without error
  • You can run chrome.storage.local.get(console.log) to check that the transactions state has been removed.

Screenshots/Recordings

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[metamaskbot]

Builds ready [b47d2af]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (89 ± 14 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	74	296	117	46	22
		domContentLoaded	49	200	84	32	15
		load	56	200	89	30	14
		domInteractive	11	83	35	15	7

Bundle size diffs [🚀 Bundle size reduced!]

• background: -15 Bytes (-0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)