Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add footers to Snap home pages #26463

Merged
merged 4 commits into from
Aug 16, 2024
Merged

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Aug 16, 2024

Description

Allow Footer in Snap home pages, this works in the same way that the new Snap dialogs does, with the exception that default footers are turned off (e.g. a cancel button is not added automatically).

Also fixes a few padding problems with home pages.

Open in GitHub Codespaces

Related issues

Closes: #25417

Manual testing steps

  1. Create a Snap that uses <Footer> in onHomePage
  2. See that the footer now shows up
  3. Install any existing Snap that doesn't use Footer
  4. See that no footer is shown

Screenshots/Recordings

home-page-footers.mp4

image

@FrederikBolding FrederikBolding requested a review from a team as a code owner August 16, 2024 09:42
@metamaskbot metamaskbot added INVALID-PR-TEMPLATE PR's body doesn't match template team-snaps-platform Snaps Platform team labels Aug 16, 2024
david0xd
david0xd previously approved these changes Aug 16, 2024
david0xd
david0xd previously approved these changes Aug 16, 2024
david0xd
david0xd previously approved these changes Aug 16, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [794c849]
Page Load Metrics (382 ± 334 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint912401223316
domContentLoaded126831157
load592363382696334
domInteractive126831157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 104 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.12%. Comparing base (2d63c0e) to head (794c849).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26463   +/-   ##
========================================
  Coverage    70.12%   70.12%           
========================================
  Files         1428     1428           
  Lines        50089    50089           
  Branches     13894    13894           
========================================
  Hits         35120    35120           
  Misses       14969    14969           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding dismissed david0xd’s stale review August 16, 2024 13:20

The merge-base changed after approval.

Copy link

@FrederikBolding FrederikBolding merged commit 4e35c94 into develop Aug 16, 2024
77 of 78 checks passed
@FrederikBolding FrederikBolding deleted the fb/home-page-footers branch August 16, 2024 13:49
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 16, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [04b720d]
Page Load Metrics (268 ± 278 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint671411072110
domContentLoaded105830136
load452174268579278
domInteractive105830136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 90 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom footer on the home page
5 participants