Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Permit ellipsis should use max 15 char #26458

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Aug 16, 2024

Description

Display max 15 characters, not max 15 digits, before ellipsis for amounts shown in Permit pages. Updated to use shortenString here.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2845

Follow-up Cherry-picked PR: #26516

Manual testing steps

  1. Go to test-dapp
  2. Trigger Malicious Permit request
  3. Observe ellipsis values in
    a. spending cap in simulation
    b. value in the message

Screenshots/Recordings

Before

After

CleanShot 2024-08-15 at 21 08 45

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested review from a team as code owners August 16, 2024 01:10
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Aug 16, 2024

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.11%. Comparing base (54b3237) to head (8e30f0a).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #26458      +/-   ##
===========================================
- Coverage    70.12%   70.11%   -0.02%     
===========================================
  Files         1428     1428              
  Lines        50103    50074      -29     
  Branches     13896    13891       -5     
===========================================
- Hits         35133    35105      -28     
+ Misses       14970    14969       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [8e30f0a]
Page Load Metrics (102 ± 25 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint794071366933
domContentLoaded11104392411
load503071025325
domInteractive11104392411
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 243 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 👍

@digiwand digiwand merged commit 4ca39b4 into develop Aug 16, 2024
83 of 84 checks passed
@digiwand digiwand deleted the fix-permit-ellipsis-15-char branch August 16, 2024 13:35
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 16, 2024
@digiwand digiwand added release-12.1.0 Issue or pull request that will be included in release 12.1.0 rc-cherry-picked and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
rc-cherry-picked release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants