-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Permit ellipsis should use max 15 char #26458
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26458 +/- ##
===========================================
- Coverage 70.12% 70.11% -0.02%
===========================================
Files 1428 1428
Lines 50103 50074 -29
Branches 13896 13891 -5
===========================================
- Hits 35133 35105 -28
+ Misses 14970 14969 -1 ☔ View full report in Codecov by Sentry. |
Builds ready [8e30f0a]
Page Load Metrics (102 ± 25 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good 👍
Description
Display max 15 characters, not max 15 digits, before ellipsis for amounts shown in Permit pages. Updated to use
shortenString
here.Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2845
Follow-up Cherry-picked PR: #26516
Manual testing steps
a. spending cap in simulation
b. value in the message
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist