Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(2946): rename back up your data to export your data #26322

Merged
merged 11 commits into from
Sep 9, 2024
Merged

Conversation

DDDDDanica
Copy link
Contributor

@DDDDDanica DDDDDanica commented Aug 2, 2024

Description

Background: The 'restore backup' feature in Extension advanced settings is currently broken and we suspect it can lead to state corruption issues.
As a short term action, we shall disable the feature until we find a way to really fix it.
Action: Rename the button to "exporting your data"

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2946

Manual testing steps

  1. Go to settings in extension
  2. Go to advanced
  3. Expect only 1 data exporting option left with updated copy

Screenshots/Recordings

Before

截屏2024-08-02 16 46 32

After

截屏2024-08-02 16 44 18

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@DDDDDanica DDDDDanica self-assigned this Aug 2, 2024
@DDDDDanica DDDDDanica requested a review from a team as a code owner August 2, 2024 15:47
Copy link
Contributor

github-actions bot commented Aug 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@DDDDDanica DDDDDanica changed the title chore(2946): disable the 'restore backup' in advanced settings to avoid state corruption Draft: chore(2946): disable the 'restore backup' in advanced settings to avoid state corruption Aug 2, 2024
@Gudahtt
Copy link
Member

Gudahtt commented Aug 2, 2024

Could you update the title to remove "Draft"? Also I don't think this is a chore, this is fixing a state corruption bug. Probably 'fix" is the better category.

@DDDDDanica DDDDDanica changed the title Draft: chore(2946): disable the 'restore backup' in advanced settings to avoid state corruption Draft: fix(2946): disable the 'restore backup' in advanced settings to avoid state corruption Aug 2, 2024
@DDDDDanica DDDDDanica force-pushed the fix/2946 branch 2 times, most recently from 1445971 to 9269d29 Compare August 2, 2024 16:22
@danjm danjm changed the title Draft: fix(2946): disable the 'restore backup' in advanced settings to avoid state corruption fix(2946): disable the 'restore backup' in advanced settings to avoid state corruption Aug 2, 2024
danjm
danjm previously approved these changes Aug 2, 2024
@DDDDDanica DDDDDanica changed the title fix(2946): disable the 'restore backup' in advanced settings to avoid state corruption DRAFT: fix(2946): disable the 'restore backup' in advanced settings to avoid state corruption Aug 2, 2024
Gudahtt
Gudahtt previously approved these changes Aug 2, 2024
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is lots more dead code to remove now in the background, but we can do that in a follow-up PR, or leave it for now until we decide whether to fix this feature or remove it for good. LGTM!

@Gudahtt Gudahtt changed the title DRAFT: fix(2946): disable the 'restore backup' in advanced settings to avoid state corruption fix(2946): disable the 'restore backup' in advanced settings to avoid state corruption Aug 2, 2024
@Gudahtt
Copy link
Member

Gudahtt commented Aug 2, 2024

I have updated the title to remove "Draft:" as well, it was failing the PR title lint check, and this is not a draft anymore.

@Gudahtt
Copy link
Member

Gudahtt commented Aug 2, 2024

Oh, still some lint errors

@Gudahtt Gudahtt added the DO-NOT-MERGE Pull requests that should not be merged label Aug 2, 2024
@Gudahtt
Copy link
Member

Gudahtt commented Aug 2, 2024

Marking this as DO-NOT-MERGE until #26325 is in, since we want that to merge first because we're including it in v12.0.1

@DDDDDanica DDDDDanica changed the title fix(2946): disable the 'restore backup' in advanced settings to avoid state corruption DO-NOT-MERGE: fix(2946): disable the 'restore backup' in advanced settings to avoid state corruption Aug 2, 2024
@HowardBraham
Copy link
Contributor

@DDDDDanica @Gudahtt should the conflicts be fixed and should this be merged now?

@DDDDDanica DDDDDanica dismissed stale reviews from Gudahtt and danjm via 4d2b5e3 August 19, 2024 23:03
@DDDDDanica DDDDDanica changed the title DO-NOT-MERGE: fix(2946): disable the 'restore backup' in advanced settings to avoid state corruption fix(2946): disable the 'restore backup' in advanced settings to avoid state corruption Aug 19, 2024
@DDDDDanica DDDDDanica changed the title fix(2946): disable the 'restore backup' in advanced settings to avoid state corruption fix(2946): rename back up your data to export your data Aug 19, 2024
@DDDDDanica DDDDDanica removed the DO-NOT-MERGE Pull requests that should not be merged label Aug 19, 2024
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good! But the constants need one more adjustment

ui/helpers/constants/settings.js Show resolved Hide resolved
@vthomas13 vthomas13 requested a review from Gudahtt August 23, 2024 16:03
Gudahtt
Gudahtt previously approved these changes Aug 23, 2024
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

itsyoboieltr
itsyoboieltr previously approved these changes Aug 26, 2024
@DDDDDanica DDDDDanica dismissed stale reviews from itsyoboieltr and Gudahtt via 8772afb September 9, 2024 16:10
Copy link

sonarcloud bot commented Sep 9, 2024

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.13%. Comparing base (739d1df) to head (8772afb).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
ui/helpers/constants/settings.js 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #26322      +/-   ##
===========================================
- Coverage    70.18%   70.13%   -0.04%     
===========================================
  Files         1425     1425              
  Lines        49662    49665       +3     
  Branches     13893    13895       +2     
===========================================
- Hits         34851    34832      -19     
- Misses       14811    14833      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [8772afb]
Page Load Metrics (1788 ± 100 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24324361591584281
domContentLoaded15222425177220699
load153424361788207100
domInteractive13145453115
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -180 Bytes (-0.00%)
  • common: -97 Bytes (-0.00%)

@DDDDDanica DDDDDanica merged commit b2fd6a5 into develop Sep 9, 2024
87 checks passed
@DDDDDanica DDDDDanica deleted the fix/2946 branch September 9, 2024 19:26
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 9, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

9 participants