-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(2946): rename back up your data to export your data #26322
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Could you update the title to remove "Draft"? Also I don't think this is a chore, this is fixing a state corruption bug. Probably 'fix" is the better category. |
1445971
to
9269d29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is lots more dead code to remove now in the background, but we can do that in a follow-up PR, or leave it for now until we decide whether to fix this feature or remove it for good. LGTM!
I have updated the title to remove "Draft:" as well, it was failing the PR title lint check, and this is not a draft anymore. |
Oh, still some lint errors |
Marking this as |
@DDDDDanica @Gudahtt should the conflicts be fixed and should this be merged now? |
…id state corruption
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good! But the constants need one more adjustment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
8772afb
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26322 +/- ##
===========================================
- Coverage 70.18% 70.13% -0.04%
===========================================
Files 1425 1425
Lines 49662 49665 +3
Branches 13893 13895 +2
===========================================
- Hits 34851 34832 -19
- Misses 14811 14833 +22 ☔ View full report in Codecov by Sentry. |
Builds ready [8772afb]
Page Load Metrics (1788 ± 100 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Description
Background: The 'restore backup' feature in Extension advanced settings is currently broken and we suspect it can lead to state corruption issues.
As a short term action, we shall disable the feature until we find a way to really fix it.
Action: Rename the button to "exporting your data"
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2946
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist