-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix create_release_pull_request
OOM error
#26249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `create_release_pull_request` job is failing due to a lack of memory during the `yarn version` step. The `yarn version` command appears to install Yarn dependencies over again. The job where we install Yarn dependencies uses a "medium" size execution environment because we encountered similar memory issues there, but the `create_release_pull_request` job is still using small. It has been updated to use a medium execution environment, which should be enough memory given that it's what `prep-deps` uses. Example failure: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/94391/workflows/4fce2a9e-2762-4c07-8617-317b0781dd27/jobs/3513290
Quality Gate passedIssues Measures |
danjm
approved these changes
Jul 31, 2024
itsyoboieltr
approved these changes
Jul 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26249 +/- ##
========================================
Coverage 69.95% 69.95%
========================================
Files 1411 1411
Lines 49963 49963
Branches 13800 13800
========================================
Hits 34948 34948
Misses 15015 15015 ☔ View full report in Codecov by Sentry. |
metamaskbot
added
the
release-12.4.0
Issue or pull request that will be included in release 12.4.0
label
Jul 31, 2024
Builds ready [ebf4d47]
Page Load Metrics (299 ± 244 ms)
Bundle size diffs
|
gauthierpetetin
added
release-12.3.0
Issue or pull request that will be included in release 12.3.0
and removed
release-12.4.0
Issue or pull request that will be included in release 12.4.0
labels
Sep 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
create_release_pull_request
job is failing due to a lack of memory during theyarn version
step. Theyarn version
command appears to install Yarn dependencies over again. The job where we install Yarn dependencies uses a "medium" size execution environment because we encountered similar memory issues there, but thecreate_release_pull_request
job is still using small.It has been updated to use a medium execution environment, which should be enough memory given that it's what
prep-deps
uses.Example failure: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/94391/workflows/4fce2a9e-2762-4c07-8617-317b0781dd27/jobs/3513290
Related issues
N/A
Manual testing steps
We should be able to reproduce this by running the job in a Docker image. But I have not tried this. Probably easier to merge it and see if it works in this case.
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist