Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix create_release_pull_request OOM error #26249

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jul 31, 2024

Description

The create_release_pull_request job is failing due to a lack of memory during the yarn version step. The yarn version command appears to install Yarn dependencies over again. The job where we install Yarn dependencies uses a "medium" size execution environment because we encountered similar memory issues there, but the create_release_pull_request job is still using small.

It has been updated to use a medium execution environment, which should be enough memory given that it's what prep-deps uses.

Example failure: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/94391/workflows/4fce2a9e-2762-4c07-8617-317b0781dd27/jobs/3513290

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

We should be able to reproduce this by running the job in a Docker image. But I have not tried this. Probably easier to merge it and see if it works in this case.

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

The `create_release_pull_request` job is failing due to a lack of
memory during the `yarn version` step. The `yarn version` command
appears to install Yarn dependencies over again. The job where we
install Yarn dependencies uses a "medium" size execution environment
because we encountered similar memory issues there, but the
`create_release_pull_request` job is still using small.

It has been updated to use a medium execution environment, which should
be enough memory given that it's what `prep-deps` uses.

Example failure: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/94391/workflows/4fce2a9e-2762-4c07-8617-317b0781dd27/jobs/3513290
@Gudahtt Gudahtt marked this pull request as ready for review July 31, 2024 15:17
@Gudahtt Gudahtt requested review from kumavis and a team as code owners July 31, 2024 15:17
Copy link

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.95%. Comparing base (07f6134) to head (ebf4d47).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26249   +/-   ##
========================================
  Coverage    69.95%   69.95%           
========================================
  Files         1411     1411           
  Lines        49963    49963           
  Branches     13800    13800           
========================================
  Hits         34948    34948           
  Misses       15015    15015           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gudahtt Gudahtt merged commit 2beba47 into develop Jul 31, 2024
79 of 81 checks passed
@Gudahtt Gudahtt deleted the fix-create-release-pull-request-memory-error branch July 31, 2024 15:38
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Jul 31, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [ebf4d47]
Page Load Metrics (299 ± 244 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint633161296531
domContentLoaded9174454220
load371610299507244
domInteractive9174454220
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants