Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Snap UI Radio component #26181

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

david0xd
Copy link
Contributor

@david0xd david0xd commented Jul 29, 2024

Waiting on release of: MetaMask/snaps#2592

Description

This PR integrates new Radio components for Snap UI.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1571

Manual testing steps

  1. Go to Test Snaps and install Interactive UI Snap.
  2. Run Interactive UI Snap by creating a dialog.
  3. Check that radio options are available in the UI and confirm their functionality. (Latest Test Snaps needs to be released before this is possible, use main branch in Snaps repo and run locally if necessary)

Screenshots/Recordings

Before

Nothing to show. Radio options were not available before.

After

Screenshot 2024-07-29 at 11 29 00
Screenshot 2024-07-29 at 11 29 17
Screenshot 2024-07-29 at 11 29 40

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@david0xd david0xd added the team-snaps-platform Snaps Platform team label Jul 29, 2024
@david0xd david0xd self-assigned this Jul 29, 2024
@david0xd david0xd changed the title Add Snap UI Radio component feat: Add Snap UI Radio component Jul 29, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@david0xd david0xd force-pushed the dd/snap-radio-ui-component branch from 6c6a39a to 47d3f34 Compare July 29, 2024 09:38
@david0xd david0xd force-pushed the dd/snap-radio-ui-component branch from a38cb2d to 7e25ae5 Compare July 31, 2024 13:34
@david0xd david0xd changed the base branch from develop to mrtenz/bump-snaps-packages July 31, 2024 13:36
Copy link

@FrederikBolding FrederikBolding force-pushed the mrtenz/bump-snaps-packages branch from b4170e0 to 8fa0ef5 Compare July 31, 2024 13:39
@david0xd david0xd force-pushed the dd/snap-radio-ui-component branch from 7e25ae5 to de807f6 Compare July 31, 2024 13:40
@david0xd david0xd marked this pull request as ready for review July 31, 2024 13:40
@david0xd david0xd requested review from a team as code owners July 31, 2024 13:40
@david0xd david0xd force-pushed the dd/snap-radio-ui-component branch from de807f6 to 8c95dac Compare August 1, 2024 11:01
@david0xd david0xd merged commit 9ec174c into mrtenz/bump-snaps-packages Aug 1, 2024
37 of 58 checks passed
@david0xd david0xd deleted the dd/snap-radio-ui-component branch August 1, 2024 11:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants