-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Snap UI Radio component #26181
Merged
david0xd
merged 4 commits into
mrtenz/bump-snaps-packages
from
dd/snap-radio-ui-component
Aug 1, 2024
Merged
feat: Add Snap UI Radio component #26181
david0xd
merged 4 commits into
mrtenz/bump-snaps-packages
from
dd/snap-radio-ui-component
Aug 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david0xd
changed the title
Add Snap UI Radio component
feat: Add Snap UI Radio component
Jul 29, 2024
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
david0xd
force-pushed
the
dd/snap-radio-ui-component
branch
from
July 29, 2024 09:38
6c6a39a
to
47d3f34
Compare
ritave
suggested changes
Jul 29, 2024
ui/components/app/snaps/snap-ui-radio-group/snap-ui-radio-group.tsx
Outdated
Show resolved
Hide resolved
ui/components/app/snaps/snap-ui-radio-group/snap-ui-radio-group.tsx
Outdated
Show resolved
Hide resolved
ritave
approved these changes
Jul 29, 2024
david0xd
force-pushed
the
dd/snap-radio-ui-component
branch
from
July 31, 2024 13:34
a38cb2d
to
7e25ae5
Compare
Quality Gate passedIssues Measures |
FrederikBolding
force-pushed
the
mrtenz/bump-snaps-packages
branch
from
July 31, 2024 13:39
b4170e0
to
8fa0ef5
Compare
david0xd
force-pushed
the
dd/snap-radio-ui-component
branch
from
July 31, 2024 13:40
7e25ae5
to
de807f6
Compare
ui/components/app/snaps/snap-ui-radio-group/snap-ui-radio-group.tsx
Outdated
Show resolved
Hide resolved
ui/components/app/snaps/snap-ui-radio-group/snap-ui-radio-group.tsx
Outdated
Show resolved
Hide resolved
david0xd
force-pushed
the
dd/snap-radio-ui-component
branch
from
August 1, 2024 11:01
de807f6
to
8c95dac
Compare
FrederikBolding
approved these changes
Aug 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on release of: MetaMask/snaps#2592
Description
This PR integrates new Radio components for Snap UI.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1571
Manual testing steps
Test Snaps
and installInteractive UI Snap
.main
branch in Snaps repo and run locally if necessary)Screenshots/Recordings
Before
Nothing to show. Radio options were not available before.
After
Pre-merge author checklist
Pre-merge reviewer checklist