fix: (cherry-pick) Remove special reject button case from api spec tests (#26048) #26051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## **Description** Merging #25769 toggled on the signatures redesign by default for all tests. This change resulted in `api-spec` tests failing. The fix is removing the logic for conditionally expect a "Reject" button instead of the default "Cancel" for some confirmations. In the redesign all signatures share the same footer. [](https://codespaces.new/MetaMask/metamask-extension/pull/26048?quickstart=1) ## **Related issues** No issue created for this test failure ## **Manual testing steps** Create a test build, then run `yarn test:api-specs` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Removed special case logic for 'Reject' button in api-spec tests to align with the new signatures redesign.
- Modified
test/e2e/api-specs/ConfirmationRejectionRule.tsto remove conditional logic for 'Reject' button. - Ensured all confirmation dialogs now expect the default 'Cancel' button.
- Simplified test logic for consistency and maintainability.
- Verified no specific scenarios requiring 'Reject' button are overlooked.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
pedronfigueiredo
changed the title
pedronfigueiredo
changed the title
digiwand
approved these changes
Jul 23, 2024
vinistevam
approved these changes
Jul 23, 2024
](https://codespaces.new/MetaMask/metamask-extension/pull/26048?quickstart=1){kind=link}
metamaskbot
added
the
release-12.2.0
|
No release label on PR. Adding release label release-12.2.0 on PR, as PR was cherry-picked in branch 12.2.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging #25769 toggled on the signatures redesign by default for all tests. This change resulted in
api-spectests failing.The fix is removing the logic for conditionally expect a "Reject" button instead of the default "Cancel" for some confirmations. In the redesign all signatures share the same footer.
Related issues
No issue created for this test failure
Manual testing steps
Create a test build, then run
yarn test:api-specsScreenshots/Recordings
Before
After
Pre-merge author checklist
Standards.
Pre-merge reviewer checklist
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist