-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding state per window in e2e, excluding null state #25900
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [d975290]
Page Load Metrics (262 ± 253 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
d975290
to
aa65cda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Builds ready [aa65cda]
Page Load Metrics (247 ± 254 ms)
Bundle size diffs
|
aa65cda
to
6f58512
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25900 +/- ##
========================================
Coverage 69.69% 69.69%
========================================
Files 1401 1401
Lines 49593 49593
Branches 13708 13708
========================================
Hits 34563 34563
Misses 15030 15030 ☔ View full report in Codecov by Sentry. |
Builds ready [6f58512]
Page Load Metrics (81 ± 21 ms)
Bundle size diffs
|
A suggestion from @hjetpoluru, this PR aims to add better context to artifacts by logging state from multiple windows, as well as removing state artifacts that are null. This is similar to #25453.
Also fixes an mv3 offscreen issue found by @HowardBraham. The runner would get hung up on taking a screenshot if it was the offscreen window.
Description
Related issues
Fixes: #25874
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist