fix: flaky test: Check the toggle for hex data #25899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [b580504]
Page Load Metrics (265 ± 262 ms)
Bundle size diffs
|
chloeYue
reviewed
Jul 17, 2024
Comment on lines
35
to
41
| if (process.env.MMI && selector === selectors.settingsDiv) { | ||
| await driver.waitForSelector(selectors.portfolioMenuOption); | ||
| await driver.clickElement(selector); | ||
| } else { | ||
| await driver.waitForSelector(selector); | ||
| await driver.clickElement(selector); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (process.env.MMI && selector === selectors.settingsDiv) { | |
| await driver.waitForSelector(selectors.portfolioMenuOption); | |
| await driver.clickElement(selector); | |
| } else { | |
| await driver.waitForSelector(selector); | |
| await driver.clickElement(selector); | |
| } | |
| if (process.env.MMI && selector === selectors.settingsDiv) { | |
| await driver.waitForSelector(selectors.portfolioMenuOption); | |
| } | |
| await driver.waitForSelector(selector); | |
| await driver.clickElement(selector); |
There was a problem hiding this comment.
@chloeYue Thanks for the suggestion! I tried it before but prefer to keep the function(clickElementsInSequence) original pattern. Thanks for understanding.
There was a problem hiding this comment.
After discussion, we agreed to keep the await driver.waitForSelector(selector); line. Suggested code changed.
vthomas13
previously approved these changes
Jul 19, 2024
|
Builds ready [dedae33]
Page Load Metrics (233 ± 243 ms)
Bundle size diffs
|
HowardBraham
approved these changes
Jul 23, 2024
chloeYue
approved these changes
Jul 24, 2024
metamaskbot
added
the
release-12.3.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to fix the flaky test occurring in the mmi build, where the dynamic menu option 'Portfolio Dashboard' is loaded and hence added the conditional wait only for the mmi build.
Related issues
Fixes: #24660
Manual testing steps
Run locally or in codespace the test using below command:-
yarn
yarn build:test:mmi
yarn test:e2e:single test/e2e/tests/settings/show-hex-data.spec.js --browser=chrome --debug --leave-running
Note:- Set the variable process.env.MMI = 'true' at the spec file when executing locally.
Validate the CI for mmi should pass.
Pre-merge author checklist
Pre-merge reviewer checklist