ci: Disabling non-lint CI on the l10n_crowdin_action branch #25809

vthomas13 · 2024-07-12T16:01:12Z

Description

Adds a new workflow to reduce the CI cost of pipelines from the translations branch l10n_crowdin_action.

Related issues

Fixes: #25770

Manual testing steps

Verify that the l10n_crowdin_action branch only runs the prep-deps, get-changed-files-with-git-diff, validate-locales-only, and test-lint.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-07-12T16:01:24Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-07-12T16:28:41Z

Builds ready [01cdf12]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (212 ± 186 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	67	331	120	67	32
		domContentLoaded	9	60	30	14	7
		load	43	1368	212	388	186
		domInteractive	9	60	30	14	7

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2024-07-12T16:28:59Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.71%. Comparing base (322b7ed) to head (17ed1a3).
Report is 2 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #25809   +/-   ##
========================================
  Coverage    69.71%   69.71%           
========================================
  Files         1400     1400           
  Lines        49462    49462           
  Branches     13691    13691           
========================================
  Hits         34478    34478           
  Misses       14984    14984

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-07-16T18:00:06Z

Builds ready [9e526cb]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (150 ± 158 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	194	105	26	13
		domContentLoaded	10	66	28	13	6
		load	44	1582	150	329	158
		domInteractive	10	66	28	13	6

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

.circleci/config.yml

.circleci/scripts/validate-locales-only.ts

.circleci/config.yml

sonarcloud · 2024-07-16T18:49:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

.circleci/scripts/validate-locales-only.ts

metamaskbot · 2024-07-16T19:20:11Z

Builds ready [e675efc]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (168 ± 177 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	82	152	112	22	10
		domContentLoaded	11	75	33	18	9
		load	46	1770	168	368	177
		domInteractive	11	75	33	18	9

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

.circleci/scripts/validate-locales-only.ts

.circleci/config.yml

Co-authored-by: Mark Stacey <[email protected]>

Co-authored-by: Howard Braham <[email protected]>

sonarcloud · 2024-07-18T17:59:31Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-07-18T20:35:08Z

Builds ready [17ed1a3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (181 ± 206 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	82	154	114	19	9
		domContentLoaded	9	68	33	17	8
		load	54	2047	181	429	206
		domInteractive	9	68	33	17	8

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

HowardBraham · 2024-07-19T23:30:48Z

@vthomas13 it's not quite working, see https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/92593/workflows/59566a28-8681-4dc8-b228-911ea9f7b507/jobs/3447247

Failure: Changed files must be in the /_locales/ directory.
 Changed Files: [
  'app/_locales/de/messages.json',
  'app/_locales/el/messages.json',
  'app/_locales/es/messages.json',
  'app/_locales/fr/messages.json',
  'app/_locales/hi/messages.json',
  'app/_locales/id/messages.json',
  'app/_locales/ja/messages.json',
  'app/_locales/ko/messages.json',
  'app/_locales/pt/messages.json',
  'app/_locales/ru/messages.json',
  'app/_locales/tl/messages.json',
  'app/_locales/tr/messages.json',
  'app/_locales/vi/messages.json',
  'app/_locales/zh_CN/messages.json',
  ''
] 
 Invalid Files: [ '' ]

vthomas13 changed the title ~~Disabling non-lint CI on the l10n_crowdin_action branch~~ ci: Disabling non-lint CI on the l10n_crowdin_action branch Jul 12, 2024

metamaskbot added the team-extension-platform label Jul 12, 2024

vthomas13 force-pushed the locales-only-workflow branch 4 times, most recently from 3d70034 to 9e526cb Compare July 16, 2024 16:57

vthomas13 marked this pull request as ready for review July 16, 2024 16:57

vthomas13 requested review from kumavis and a team as code owners July 16, 2024 16:57

vthomas13 requested review from danjm, seaona, DDDDDanica and itsyoboieltr July 16, 2024 17:12

Gudahtt reviewed Jul 16, 2024

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

Gudahtt reviewed Jul 16, 2024

View reviewed changes

.circleci/scripts/validate-locales-only.ts Outdated Show resolved Hide resolved

Gudahtt reviewed Jul 16, 2024

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

Gudahtt requested changes Jul 16, 2024

View reviewed changes

.circleci/config.yml Show resolved Hide resolved

.circleci/config.yml Outdated Show resolved Hide resolved

vthomas13 requested a review from Gudahtt July 16, 2024 18:53

Gudahtt reviewed Jul 16, 2024

View reviewed changes

.circleci/scripts/validate-locales-only.ts Outdated Show resolved Hide resolved

HowardBraham reviewed Jul 16, 2024

View reviewed changes

.circleci/scripts/validate-locales-only.ts Show resolved Hide resolved

HowardBraham reviewed Jul 17, 2024

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

.circleci/config.yml Outdated Show resolved Hide resolved

.circleci/config.yml Outdated Show resolved Hide resolved

vthomas13 force-pushed the locales-only-workflow branch from e675efc to 7d67874 Compare July 17, 2024 15:43

vthomas13 requested a review from a team as a code owner July 17, 2024 15:43

vthomas13 force-pushed the locales-only-workflow branch from 4b7b030 to 9fb0081 Compare July 17, 2024 16:14

vthomas13 and others added 22 commits July 18, 2024 13:57

adding locales-only workflow, filtering on test branch name

8a8daa7

test using when/unless instead of branches only/ignore

19988ac

test pattern matching for new workflow

0ac039a

removing condition from logic at workflow level

210fa89

Added validate-locales-only job

b5fa9a2

test logging changed files

a0d7778

adding edge case and documentation

b256d1d

switching branches to l10n_crowdin_action

3a2ab08

adding test-lint step to locales_only workflow

92a048e

testing test branch

7f79f7d

excluding this branch from git diff

b18728b

reverting commit, adding prerequisite steps for test-lint

6291ed5

removing test branch name

7653b80

Update .circleci/scripts/validate-locales-only.ts

576a214

Co-authored-by: Mark Stacey <[email protected]>

formatting

2aa5ae3

Apply suggestions from code review

8e6ef3b

Co-authored-by: Mark Stacey <[email protected]>

adding all-steps-pass job to locales_only workflow

5dca8a0

cleanup

629e520

Update .circleci/config.yml

3cb5e72

Co-authored-by: Howard Braham <[email protected]>

exiting job when readChangedFiles returns null or empty array

51cff9b

test

3921088

undo test

17ed1a3

vthomas13 force-pushed the locales-only-workflow branch from 10c50e3 to 17ed1a3 Compare July 18, 2024 17:57

vthomas13 merged commit e562224 into develop Jul 18, 2024
79 checks passed

vthomas13 deleted the locales-only-workflow branch July 18, 2024 20:35

github-actions bot locked and limited conversation to collaborators Jul 18, 2024

metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: Disabling non-lint CI on the l10n_crowdin_action branch #25809

ci: Disabling non-lint CI on the l10n_crowdin_action branch #25809

vthomas13 commented Jul 12, 2024 •

edited

Loading

github-actions bot commented Jul 12, 2024

metamaskbot commented Jul 12, 2024

codecov bot commented Jul 12, 2024 •

edited

Loading

metamaskbot commented Jul 16, 2024

sonarcloud bot commented Jul 16, 2024

metamaskbot commented Jul 16, 2024

sonarcloud bot commented Jul 18, 2024

metamaskbot commented Jul 18, 2024

HowardBraham commented Jul 19, 2024

ci: Disabling non-lint CI on the l10n_crowdin_action branch #25809

ci: Disabling non-lint CI on the l10n_crowdin_action branch #25809

Conversation

vthomas13 commented Jul 12, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jul 12, 2024

metamaskbot commented Jul 12, 2024

codecov bot commented Jul 12, 2024 • edited Loading

Codecov Report

metamaskbot commented Jul 16, 2024

sonarcloud bot commented Jul 16, 2024

Quality Gate passed

metamaskbot commented Jul 16, 2024

sonarcloud bot commented Jul 18, 2024

Quality Gate passed

metamaskbot commented Jul 18, 2024

HowardBraham commented Jul 19, 2024

vthomas13 commented Jul 12, 2024 •

edited

Loading

codecov bot commented Jul 12, 2024 •

edited

Loading