Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update @metamask/bitcoin-wallet-snap to 0.2.4 #25808

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Jul 12, 2024

Description

Bump the BTC Snap to version 0.2.4.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ccharly ccharly self-assigned this Jul 12, 2024
@ccharly ccharly requested a review from a team as a code owner July 12, 2024 15:34
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 12, 2024
Copy link

sonarcloud bot commented Jul 12, 2024

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] network 0 1.06 MB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@ccharly
Copy link
Contributor Author

ccharly commented Jul 12, 2024

Not sure why the "INVALID-PR-TEMPLATE" got added, maybe I did remove too many comments from it.

@metamaskbot
Copy link
Collaborator

Builds ready [9962740]
Page Load Metrics (248 ± 254 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint682981144622
domContentLoaded105727157
load512050248528254
domInteractive105727157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -7.37 KiB (-0.10%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.96%. Comparing base (24c95db) to head (9962740).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25808   +/-   ##
========================================
  Coverage    69.96%   69.96%           
========================================
  Files         1390     1390           
  Lines        48919    48919           
  Branches     13460    13460           
========================================
  Hits         34226    34226           
  Misses       14693    14693           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ccharly ccharly removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 12, 2024
@danroc danroc merged commit 9f95f30 into develop Jul 12, 2024
92 checks passed
@danroc danroc deleted the feature/use-bitcoin-wallet-snap-0.2.4 branch July 12, 2024 20:53
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants