fix: missing deadline in swaps stx status screen #25779

infiniteflower · 2024-07-11T17:31:00Z

Description

This PR fixes an issue where the STX status screen for a swap was showing a 0:00 for the timer.

Related issues

Related to: #25063

Manual testing steps

Make sure Smart Transactions is on (Settings > Advanced)
Do a Swap
Observe that timer is not 0:00 and is a reasonable number

Screenshots/Recordings

Before

Screen.Recording.2024-07-10.at.2.41.53.PM.mov

After

Screen.Recording.2024-07-11.at.1.28.53.PM.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-07-11T17:31:13Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sonarcloud · 2024-07-15T20:32:29Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-08-16T20:23:45Z

Builds ready [190ac46]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (74 ± 14 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	69	210	102	32	15
		domContentLoaded	39	185	69	30	14
		load	46	185	74	28	14
		domInteractive	9	139	34	27	13

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 62 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2024-08-16T20:24:20Z

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.96%. Comparing base (fc3da74) to head (84ac8b4).
Report is 1 commits behind head on develop.

Files	Patch %	Lines
app/scripts/controllers/swaps/index.ts	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25779      +/-   ##
===========================================
- Coverage    69.96%   69.96%   -0.00%     
===========================================
  Files         1405     1405              
  Lines        49000    49003       +3     
  Branches     13699    13701       +2     
===========================================
  Hits         34282    34282              
- Misses       14718    14721       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dan437

Thanks for adding the fallback! One thing: this PR adds a fallback for the deadline, but it should use a value from backend in the first place. Can you check if the value from backend is being used?

dan437 · 2024-08-19T10:24:33Z

test/e2e/tests/metrics/state-snapshots/errors-after-init-opt-in-ui-state.json

@@ -247,6 +247,7 @@
      "swapsQuoteRefreshTime": 60000,
      "swapsQuotePrefetchingRefreshTime": 60000,
      "swapsStxBatchStatusRefreshTime": 10000,
+      "swapsStxStatusDeadline": "number",


Why is this a "number" string and not some exact number like other fallback values?

The value wasn't being set up correctly in the test, but it is now 👍

metamaskbot · 2024-08-19T20:04:36Z

Builds ready [596e722]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (72 ± 6 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	70	135	98	17	8
		domContentLoaded	49	85	66	12	6
		load	49	92	72	12	6
		domInteractive	10	41	27	9	4

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 194 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

…dline

metamaskbot · 2024-08-19T21:37:37Z

Builds ready [af3c138]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (78 ± 8 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	77	158	107	21	10
		domContentLoaded	42	119	74	19	9
		load	51	119	78	17	8
		domInteractive	12	58	27	11	5

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 194 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 26 Bytes (0.00%)

martahj · 2024-08-19T21:48:25Z

Thanks for adding the fallback! One thing: this PR adds a fallback for the deadline, but it should use a value from backend in the first place. Can you check if the value from backend is being used?

@dan437 You were right - the fallback rather than the value from the PR was used. I pushed some updates and that is no longer the case.

sonarcloud · 2024-08-20T12:58:04Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-08-20T13:29:44Z

Builds ready [84ac8b4]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (66 ± 7 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	58	146	92	19	9
		domContentLoaded	38	100	60	15	7
		load	44	108	66	15	7
		domInteractive	9	44	21	8	4

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 194 Bytes (0.01%)
ui: 0 Bytes (0.00%)
common: 26 Bytes (0.00%)

fix: missing deadline in swaps stx status screen

c4a4cf0

infiniteflower requested a review from a team as a code owner July 11, 2024 17:31

infiniteflower added the team-swaps label Jul 11, 2024

infiniteflower added 5 commits July 12, 2024 13:47

Merge branch 'develop' into fix/swaps-stx-timer

a7a38a2

fix: broken tests

924a839

Merge branch 'develop' into fix/swaps-stx-timer

0f2764f

chore: update snapshots for tests

e267f6d

chore: attempt at fixing tests

fb970d5

Merge branch 'develop' into fix/swaps-stx-timer-rebased

691de5b

martahj requested a review from a team as a code owner August 16, 2024 18:26

fix: updates snapshot value for swaps stx tx deadline

190ac46

martahj previously approved these changes Aug 16, 2024

View reviewed changes

dan437 reviewed Aug 19, 2024

View reviewed changes

digiwand previously approved these changes Aug 19, 2024

View reviewed changes

fix: include swaps stx status deadline from api

596e722

martahj dismissed stale reviews from digiwand and themself via 596e722 August 19, 2024 16:56

fix: update tests to use number instead of type for swapsStxStatusDea…

af3c138

…dline

benjisclowder requested review from dan437 and martahj August 20, 2024 09:05

dan437 approved these changes Aug 20, 2024

View reviewed changes

Merge branch 'develop' into fix/swaps-stx-timer

84ac8b4

martahj approved these changes Aug 20, 2024

View reviewed changes

martahj merged commit 9ee22f8 into develop Aug 20, 2024
78 checks passed

martahj deleted the fix/swaps-stx-timer branch August 20, 2024 13:46

github-actions bot locked and limited conversation to collaborators Aug 20, 2024

metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 20, 2024

gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: missing deadline in swaps stx status screen #25779

fix: missing deadline in swaps stx status screen #25779

infiniteflower commented Jul 11, 2024 •

edited

Loading

github-actions bot commented Jul 11, 2024

sonarcloud bot commented Jul 15, 2024

metamaskbot commented Aug 16, 2024

codecov bot commented Aug 16, 2024 •

edited

Loading

dan437 left a comment

dan437 Aug 19, 2024

martahj Aug 19, 2024

metamaskbot commented Aug 19, 2024

metamaskbot commented Aug 19, 2024

martahj commented Aug 19, 2024

sonarcloud bot commented Aug 20, 2024

metamaskbot commented Aug 20, 2024

fix: missing deadline in swaps stx status screen #25779

fix: missing deadline in swaps stx status screen #25779

Conversation

infiniteflower commented Jul 11, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jul 11, 2024

sonarcloud bot commented Jul 15, 2024

Quality Gate passed

metamaskbot commented Aug 16, 2024

codecov bot commented Aug 16, 2024 • edited Loading

Codecov Report

dan437 left a comment

Choose a reason for hiding this comment

dan437 Aug 19, 2024

Choose a reason for hiding this comment

martahj Aug 19, 2024

Choose a reason for hiding this comment

metamaskbot commented Aug 19, 2024

metamaskbot commented Aug 19, 2024

martahj commented Aug 19, 2024

sonarcloud bot commented Aug 20, 2024

Quality Gate passed

metamaskbot commented Aug 20, 2024

infiniteflower commented Jul 11, 2024 •

edited

Loading

codecov bot commented Aug 16, 2024 •

edited

Loading